Review main Merged

53001[TASK] SystemInformationMenu: Automatically refresh counter badge

Johannes Goslar CR +2 V +2 Easy +23 −5 updated 06/02/17, 09:25

Commit message

Automatically reload the SystemInformation every 5 minutes.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Johannes Goslar +1
    • Sascha Egerer +1
  • Verified V +2
    • Christian Kuhn +2
    • Sascha Egerer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1822

  1. Johannes Goslar uploaded patch set 1 06/01/17, 16:27

  2. TYPO3com voted on patch set 1 V +1 06/01/17, 16:36 Completed build in 09m 08s on Thu, 1 Jun, 06:36 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11967

  3. Georg Ringer commented on patch set 1 CR -1 06/01/17, 16:51

    if it is a feature, an rst is missing
  4. Oliver Hader commented on patch set 1 06/01/17, 16:53

    Let's make it a task then... this change does not qualify a RST file with ("... updates automatically now, you don't have to reload the whole backend ...")
  5. Oliver Hader uploaded patch set 2 06/01/17, 17:41

  6. Oliver Hader commented on patch set 2 CR +1 V +1 06/01/17, 17:45

    SystemInformationMenu.js:103

    Just out of curiosity, is this class required?
  7. Oliver Hader commented on patch set 2 06/01/17, 17:46

    Note: For the version 8 backport, we need to add skipSessionUpdate for the AJAX call
  8. TYPO3com voted on patch set 2 V +1 06/01/17, 17:49 Completed build in 07m 08s on Thu, 1 Jun, 07:49 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11975

  9. Oliver Hader uploaded patch set 3 06/01/17, 18:54

  10. Oliver Hader commented on patch set 2 06/01/17, 18:54

    SystemInformationMenu.js:103 Reply

    Done
  11. Oliver Hader voted on patch set 3 CR +1 V +1 06/01/17, 18:56

  12. Johannes Goslar voted on patch set 3 CR +1 V +1 06/01/17, 18:59

  13. TYPO3com voted on patch set 3 V +1 06/01/17, 19:01 Completed build in 07m 07s on Thu, 1 Jun, 09:01 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11977

  14. Sascha Egerer commented on patch set 3 CR -1 06/01/17, 19:08

    SystemInformationMenu.js:106

    This class should never be removed, right? So it should be added in 103 again and not in this condition.
  15. Oliver Hader commented on patch set 3 06/01/17, 19:36

    SystemInformationMenu.js:106 Reply

    Not sure about the whole line at all (already prior to this patch). These classes are part of the markup already (ToolbarItems/SystemInformationToolbarItem.html). Thus the only class in question would be the one in variable badgetClass. Maybe you'd like to double check that as well. Thx :)
  16. Oliver Hader uploaded patch set 4 06/01/17, 20:09

  17. TYPO3com voted on patch set 4 V +1 06/01/17, 20:18 Completed build in 09m 05s on Thu, 1 Jun, 10:18 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11985

  18. Johannes Goslar voted on patch set 4 CR +1 06/01/17, 20:59

  19. Sascha Egerer voted on patch set 4 CR +1 V +1 06/02/17, 08:47

  20. Christian Kuhn voted on patch set 4 CR +2 V +2 06/02/17, 09:25

  21. Gerrit merged patch set 4 06/02/17, 09:25

  22. Christian Kuhn commented on patch set 5 06/02/17, 09:25

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 12b241deb8f54185bf931c528af68a13dbd077af