Review main Merged

53003[TASK] Require bower and have node build scripts

Christian Kuhn CR +2 V +2 Easy +6 −0 updated 06/01/17, 17:28

Commit message

In preperation of a scss linter and typescript linter
we require bower as root dev dependency and register
some happy little scripts.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Markus Sommer +1
    • Benjamin Kott +1
  • Verified V +2
    • Christian Kuhn +2
    • Markus Sommer +1
    • Benjamin Kott +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Christian Kuhn uploaded patch set 1 06/01/17, 17:08

  2. Markus Sommer commented on patch set 1 CR +1 V +1 06/01/17, 17:11

    Happy little bug free :)
  3. TYPO3com voted on patch set 1 V +1 06/01/17, 17:15 Completed build in 06m 29s on Thu, 1 Jun, 07:15 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11973

  4. Benjamin Kott voted on patch set 1 CR +2 V +2 06/01/17, 17:27

  5. Benjamin Kott voted on patch set 1 CR +1 V +1 06/01/17, 17:27

  6. Christian Kuhn voted on patch set 1 CR +2 V +2 06/01/17, 17:27

  7. Gerrit merged patch set 1 06/01/17, 17:27

  8. Christian Kuhn commented on patch set 2 06/01/17, 17:28

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit abd081391fd64918c4ed7d4ce42f8ec89ed2c962