Review main Merged

53023[BUGFIX] Fix height of the modal content

Jasmina Ließmann CR +2 V +2 Easy +7 −6 updated 06/04/17, 09:53

Commit message

Fix height of the modal content to avoid misbehavior in IE11.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Markus Sommer +1
    • Benjamin Kott +1
  • Verified V +2
    • Christian Kuhn +2
    • Markus Sommer +1
    • Benjamin Kott +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1220

  1. Jasmina Ließmann uploaded patch set 1 06/02/17, 10:18

  2. TYPO3com voted on patch set 1 V +1 06/02/17, 10:34 Completed build in 16m 21s on Fri, 2 Jun, 12:34 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12036

  3. Jasmina Ließmann uploaded patch set 2 06/02/17, 14:08

  4. TYPO3com voted on patch set 2 V -1 06/02/17, 14:09 Completed build in 06s on Fri, 2 Jun, 04:09 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12091

  5. TYPO3com commented on patch set 2 06/02/17, 14:10 Completed build in 01m 44s on Fri, 2 Jun, 04:10 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12091

  6. Jasmina Ließmann uploaded patch set 3 06/02/17, 20:22

  7. Christian Kuhn updated the commit message in patch set 4 06/02/17, 20:28

  8. TYPO3com voted on patch set 3 V +1 06/02/17, 20:31 Completed build in 09m 16s on Fri, 2 Jun, 10:31 PM Test Summary: 55931 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12137

  9. TYPO3com voted on patch set 4 V +1 06/02/17, 20:41 Completed build in 12m 29s on Fri, 2 Jun, 10:41 PM Test Summary: 55931 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12140

  10. Christian Kuhn commented on patch set 4 CR -1 06/02/17, 21:33

    not a fan of this general height increase for all browsers.
  11. Jasmina Ließmann uploaded patch set 5 06/03/17, 23:22

  12. TYPO3com voted on patch set 5 V +1 06/03/17, 23:29 Completed build in 07m 27s on Sun, 4 Jun, 01:29 AM Test Summary: 2334 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12281

  13. Markus Sommer uploaded patch set 6 06/03/17, 23:35

  14. TYPO3com voted on patch set 6 V +1 06/03/17, 23:43 Completed build in 07m 33s on Sun, 4 Jun, 01:43 AM Test Summary: 2334 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12282

  15. Jasmina Ließmann uploaded patch set 7 06/04/17, 08:48

  16. TYPO3com voted on patch set 7 V +1 06/04/17, 08:56 Completed build in 07m 27s on Sun, 4 Jun, 10:56 AM Test Summary: 2334 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12291

  17. Benjamin Kott voted on patch set 7 CR +1 V +1 06/04/17, 09:49

  18. Markus Sommer voted on patch set 7 CR +1 V +1 06/04/17, 09:53

  19. Christian Kuhn voted on patch set 7 CR +2 V +2 06/04/17, 09:53

  20. Gerrit merged patch set 7 06/04/17, 09:53