Review TYPO3_8-7 Merged

53029[BUGFIX] Remove disabled button in inline records

Christian Kuhn CR +2 V +2 Easy +6 −4 updated 06/02/17, 11:26

Commit message

If the info icon is disabled it is now removed completely.
Previously the logic for new records was not caught correctly, so that
the case for the enabled icon with a new record was executed.
Disabling the icon should remove it completely,
as a disabled non-clickable icon is not helpful and confusing for editors.
This is now done, and the case for the enabled icon with new records is
also correctly caught.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Christian Kuhn commented on patch set 1 06/02/17, 11:15

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 06/02/17, 11:24 Completed build in 09m 16s on Fri, 2 Jun, 01:24 PM Test Summary: 56777 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-276

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 06/02/17, 11:26

  4. Gerrit merged patch set 1 06/02/17, 11:26