Review main Merged

53031[BUGFIX] Editing all records after deleting one throws exception

Oliver Hader CR +2 V +2 Normal +107 −48 updated 06/02/17, 13:28

Commit message

If some record has been removed in the list module and after that
the "edit marked" button is clicked, an exception is thrown concerning
the just removed record.

The list of records to be edited is now determined from the visible
elements of the list.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1523

  1. Oliver Hader uploaded patch set 1 06/02/17, 12:00

  2. Christian Kuhn commented on patch set 1 06/02/17, 12:04

    AbstractDatabaseRecordList.php:1373

    can't we use GeneralUtility::implodeAttributes here?
  3. Oliver Hader uploaded patch set 2 06/02/17, 12:05

  4. TYPO3com voted on patch set 1 V -1 06/02/17, 12:08 Completed build in 07m 35s on Fri, 2 Jun, 02:08 PM Test Summary: 55889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12057

  5. TYPO3com voted on patch set 2 V -1 06/02/17, 12:15 Completed build in 10m 26s on Fri, 2 Jun, 02:15 PM Test Summary: 55931 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12060

  6. Oliver Hader uploaded patch set 3 06/02/17, 12:20

  7. Oliver Hader commented on patch set 1 06/02/17, 12:23

    AbstractDatabaseRecordList.php:1373 Reply

    Done
  8. TYPO3com voted on patch set 3 V -1 06/02/17, 12:26 Completed build in 05m 44s on Fri, 2 Jun, 02:26 PM Test Summary: 55931 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12063

  9. Oliver Hader uploaded patch set 4 06/02/17, 12:29

  10. Oliver Hader updated the commit message in patch set 5 06/02/17, 12:30

  11. TYPO3com voted on patch set 5 V +1 06/02/17, 12:41 Completed build in 11m 06s on Fri, 2 Jun, 02:41 PM Test Summary: 55931 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12066

  12. Oliver Hader uploaded patch set 6 06/02/17, 12:42

  13. TYPO3com voted on patch set 6 V -1 06/02/17, 12:50 Completed build in 07m 35s on Fri, 2 Jun, 02:50 PM Test Summary: 1 of 55934 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12068

  14. Oliver Hader uploaded patch set 7 06/02/17, 12:55

  15. Oliver Hader uploaded patch set 8 06/02/17, 13:03

  16. TYPO3com voted on patch set 7 V +1 06/02/17, 13:03 Completed build in 08m 20s on Fri, 2 Jun, 03:03 PM Test Summary: 55931 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12070

  17. TYPO3com voted on patch set 8 V +1 06/02/17, 13:09 Completed build in 06m 11s on Fri, 2 Jun, 03:09 PM Test Summary: 55931 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12072

  18. Susi Moog voted on patch set 8 CR +1 V +1 06/02/17, 13:12

  19. Jasmina Ließmann voted on patch set 8 CR +1 V +1 06/02/17, 13:14

  20. TYPO3com voted on patch set 4 V +1 06/02/17, 13:25 Completed build in 1h 22m 24s on Fri, 2 Jun, 03:25 PM Test Summary: 55931 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12065

  21. Christian Kuhn voted on patch set 8 CR +2 V +2 06/02/17, 13:28

  22. Gerrit merged patch set 8 06/02/17, 13:28

  23. Christian Kuhn commented on patch set 9 06/02/17, 13:28

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 0ecf16af2766941e1928c177b4c6f292bbad5bf8