53040[FEATURE] Collect lost elements and show them separately from backend layout
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Mona Muzaffar +1
-
Verified V +2
- Christian Kuhn +2
- Jasmina Ließmann +1
- Riccardo De Contardi +1
- Mona Muzaffar +1
- TYPO3com +1 CI
Issues 1
Files 6
- Build/Resources/Public/Sass/typo3/_module_web_page.scss+40 −4
- typo3/sysext/backend/Classes/View/PageLayoutView.php5+65 −25
- typo3/sysext/backend/Resources/Private/Language/locallang_layout.xlf+6 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/LayoutModule/DragDrop.js+1 −3
- typo3/sysext/frontend/Resources/Private/Language/locallang_ttc.xlf+3 −0
Review log 3043
Show 1118 earlier messages
-
Jo Hasenau uploaded patch set 1 06/02/17, 13:24
-
TYPO3com voted on patch set 1 V -1 06/02/17, 13:32 Completed build in 08m 04s on Fri, 2 Jun, 03:32 PM Test Summary: 55931 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12076
-
Jo Hasenau uploaded patch set 2 06/02/17, 15:01
-
Jo Hasenau uploaded patch set 3 06/02/17, 15:05
-
TYPO3com voted on patch set 2 V +1 06/02/17, 15:08 Completed build in 07m 00s on Fri, 2 Jun, 05:08 PM Test Summary: 55931 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12101
-
TYPO3com voted on patch set 3 V +1 06/02/17, 15:15 Completed build in 09m 55s on Fri, 2 Jun, 05:15 PM Test Summary: 55931 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12102
-
Jo Hasenau uploaded patch set 4 06/02/17, 16:18
-
TYPO3com voted on patch set 4 V +1 06/02/17, 16:28 Completed build in 09m 40s on Fri, 2 Jun, 06:28 PM Test Summary: 55931 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12111
-
Marco Christian Krenn uploaded patch set 5 06/02/17, 16:58
-
Jasmina Ließmann commented on patch set 5 V +1 06/02/17, 17:11
testet with master. at the moment beneath every column a new column "unused" is displayed (page view). I prefer only one column "unused" at the very bottom of the page view, otherwise it is a little bit confusing. -
TYPO3com voted on patch set 5 V +1 06/02/17, 17:12 Completed build in 13m 58s on Fri, 2 Jun, 07:12 PM Test Summary: 55931 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12119
-
Riccardo De Contardi commented on patch set 5 06/02/17, 17:15
with some configuration the "unused" section is repeated twice :S -
Jo Hasenau uploaded patch set 6 06/02/17, 17:20
-
TYPO3com voted on patch set 6 V -1 06/02/17, 17:20 Completed build in 06s on Fri, 2 Jun, 07:20 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12125
-
Jo Hasenau commented on patch set 6 06/02/17, 20:02
@Riccardo - Could you please specify "some configuration" within the forge ticket, so we can test that here? -
Jo Hasenau uploaded patch set 7 06/02/17, 20:17
-
TYPO3com voted on patch set 7 V -1 06/02/17, 20:17 Completed build in 06s on Fri, 2 Jun, 10:17 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12136
-
Marco Christian Krenn uploaded patch set 8 06/02/17, 20:24
-
TYPO3com voted on patch set 8 V +1 06/02/17, 20:38 Completed build in 14m 42s on Fri, 2 Jun, 10:38 PM Test Summary: 55931 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12138
-
Jo Hasenau uploaded patch set 9 06/02/17, 21:11
-
TYPO3com voted on patch set 9 V -1 06/02/17, 21:24 Completed build in 12m 58s on Fri, 2 Jun, 11:24 PM Test Summary: 55931 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12147
-
Jo Hasenau uploaded patch set 10 06/02/17, 21:32
-
TYPO3com voted on patch set 10 V +1 06/02/17, 21:40 Completed build in 07m 52s on Fri, 2 Jun, 11:40 PM Test Summary: 55931 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12151
-
Jo Hasenau uploaded patch set 11 06/02/17, 22:13
-
TYPO3com voted on patch set 11 V +1 06/02/17, 22:23 Completed build in 09m 52s on Sat, 3 Jun, 12:23 AM Test Summary: 55931 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12157
-
Riccardo De Contardi voted on patch set 11 V +1 06/02/17, 22:28
-
Jasmina Ließmann voted on patch set 11 V +1 06/02/17, 22:31
-
Mona Muzaffar commented on patch set 11 06/03/17, 00:11
not too sure about the warning in the top of the module body, because you can't really suppress the warning and if for some reason you don't want to delete these elements or move them yet, it could be annoying. Or is it meant to kind of force the user to deal with it? Would it be too much work to give the column a label? if you have quiet many content elements, have to scroll down and you don't see the warning anymore, a label 'unused or unallocated elements' would be nice.PageLayoutView.php:66is the 'no' a typo? -
Christian Kuhn commented on patch set 11 CR -1 06/03/17, 08:23
minor details, only.PageLayoutView.php:66Replylooks so.PageLayoutView.php:1236why the removal of array type hint? -
Jo Hasenau commented on patch set 11 06/03/17, 08:29
@Mona There is a label in locallang_ttc.xlf, so if you don't see it, it might be a caching problemPageLayoutView.php:66ReplyYes - will be fixed.PageLayoutView.php:1236ReplyBecause it was converted to a string in between - but now since it is an array again, this should be fixed -
Jo Hasenau uploaded patch set 12 06/03/17, 08:40
-
TYPO3com voted on patch set 12 V +1 06/03/17, 08:49 Completed build in 08m 29s on Sat, 3 Jun, 10:49 AM Test Summary: 55931 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12168
-
Jo Hasenau uploaded patch set 13 06/03/17, 09:47
-
Christian Kuhn voted on patch set 13 CR +1 V +1 06/03/17, 09:50
-
Christian Kuhn commented on patch set 13 06/03/17, 09:51
revotes pls -
TYPO3com voted on patch set 13 V +1 06/03/17, 09:55 Completed build in 08m 12s on Sat, 3 Jun, 11:55 AM Test Summary: 55931 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12176
-
Mona Muzaffar voted on patch set 13 CR +1 V +1 06/03/17, 10:11
-
Riccardo De Contardi commented on patch set 13 V +1 06/03/17, 10:18
Now that I am thinking of it... what would happen with the extensions like jh_magnificpopup (that uses colPos=109) ? -
Jasmina Ließmann voted on patch set 13 V +1 06/03/17, 10:22
-
Christian Kuhn commented on patch set 13 06/03/17, 10:26
yeah riccardo, that's a valid use case: having some elements on invisible columns by design. this also happens if you have irre relations to tt_content elements on same page and don't want to see the children in page. we'll need a generic solution for that, but that should be done in another patch. -
Christian Kuhn commented on patch set 13 CR +2 V +2 06/03/17, 10:31
jo will have a look if we could allow null as value for colPos to solve this use case in a technical correct way. -
Gerrit merged patch set 13 06/03/17, 10:31
-
Claus Due commented on patch set 14 08/26/17, 20:01
I propose using a signal to allow third party code to affect the used/unused decision: https://review.typo3.org/#/c/53811 Reasons for preferring this over for example an array of exempt colPos values: * It allows any of the record's attributes to determine if a record is unused, as such it is a lot more flexible when combined with for example hooks and custom TS rendering that changes the normal colPos handling. * It allows the check to be dynamic, e.g. it can depend on for example what's currently in the $columns array. * It is completely separate from the existing backend layout implementations which is a good thing.