Review TYPO3_8-7 Merged

53048[TASK] Add type hints and fix PHPDoc in extbase DataMapFactory

Susi Moog CR +2 V +2 Easy +7 −7 updated 06/03/17, 08:14

Commit message

While this is technically a breaking change it only affects internal API.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Mona Muzaffar +1
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Susi Moog commented on patch set 1 06/02/17, 14:12

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 06/02/17, 14:33 Completed build in 20m 48s on Fri, 2 Jun, 04:33 PM Test Summary: 56777 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-286

  3. Mona Muzaffar voted on patch set 1 CR +1 06/03/17, 00:43

  4. Christian Kuhn voted on patch set 1 CR +2 V +2 06/03/17, 08:14

  5. Gerrit merged patch set 1 06/03/17, 08:14