Review main Merged

53077[FEATURE] Add .inline property to includeCSS/includeCSSLibs

Raphael Graf CR +2 V +2 Normal +106 −30 updated 08/14/17, 12:00

Commit message

If .inline is set, the contents of the css-file is inlined
using <style>-tags.

.inline implies .excludeFromConcatenation.
.import takes precedence over .inline.
The other properties of includeCSS still work if .inline is set.

Review

  • Code review CR +2
    • Susi Moog +2
    • Henning Liebe +1
  • Verified V +2
    • Susi Moog +2
    • Henning Liebe +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 3041

Show 1316 earlier messages
  1. Raphael Graf uploaded patch set 1 06/03/17, 10:55

  2. TYPO3com voted on patch set 1 V +1 06/03/17, 11:03 Completed build in 07m 53s on Sat, 3 Jun, 01:03 PM Test Summary: 55931 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12186

  3. Susi Moog uploaded patch set 2 06/03/17, 17:17

  4. Susi Moog commented on patch set 2 06/03/17, 17:18

    Added .rst documentation file for this feature. Even though it is a feature, I'd say 8.7 is ok as the impact / possible side effects are low and demand for it are high.
  5. TYPO3com voted on patch set 2 V -1 06/03/17, 17:39 Completed build in 22m 08s on Sat, 3 Jun, 07:39 PM Test Summary: 1 of 2390 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12252

  6. TYPO3com voted on patch set 2 V +1 06/03/17, 18:29 Completed build in 1h 34m 41s on Sat, 3 Jun, 08:29 PM Test Summary: 2387 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12252

  7. Christian Kuhn commented on patch set 2 06/03/17, 18:33

    not for 8.7. isn't there an .external setting or something similar? what happens in this case?
  8. Raphael Graf commented on patch set 2 06/04/17, 17:28

    > not for 8.7. > isn't there an .external setting or something similar? what happens > in this case? In the following example, css1 is inlined while css2 is not. Is this expected behaviour? includeCss { css1 = test.css css1.external = 1 css1.forceInline = 1 css2 = http://typo3.org/test.css css2.external = 1 css2.forceInline = 1 }
  9. David Hoeckele voted on patch set 2 CR +1 06/07/17, 16:00

  10. Susi Moog commented on patch set 2 06/12/17, 06:45

    The behaviour for external is documented in the rst file (and in the forge issue), so yes the behaviour is expected.
  11. Manuel Wohlers commented on patch set 2 CR +1 06/13/17, 13:23

    I like this feature! personally I would call the setting "inline" not "forceInline" because it's not forced at all. (e.g. "external" and "import" both take precedence)
  12. Benni Mack commented on patch set 2 06/13/17, 14:48

    I wonder why you just don't use cssInline? https://docs.typo3.org/typo3cms/TyposcriptReference/Setup/Page/Index.html#cssinline page.cssInline.10 = FILE page.cssInline.10.file = typo3conf/ext/site_mysite/Resources/Public/StyleSheets/mystyles.css
  13. Raphael Graf commented on patch set 2 06/13/17, 20:02

    > I wonder why you just don't use cssInline? > > https://docs.typo3.org/typo3cms/TyposcriptReference/Setup/Page/Index.html#cssinline > > page.cssInline.10 = FILE > page.cssInline.10.file = typo3conf/ext/site_mysite/Resources/Public/StyleSheets/mystyles.css > I wonder why you just don't use cssInline? > > https://docs.typo3.org/typo3cms/TyposcriptReference/Setup/Page/Index.html#cssinline > > page.cssInline.10 = FILE > page.cssInline.10.file = typo3conf/ext/site_mysite/Resources/Public/StyleSheets/mystyles.css This works if config.inlineStyle2TempFile is disabled. The only advantages of .forceInline are: - config.compressCSS=1 works. - Some features of includeCss (like .media, .title, .if) may be useful for inline CSS too. - It is easier to maintain the list of CSS files in only one typoscript block.
  14. Simon Schaufelberger commented on patch set 2 06/13/17, 21:34

    I would also name it "inline"
  15. Frank Nägler commented on patch set 2 06/17/17, 15:58

    1) I like this new feature 2) I would prefer also "inline" instead of "forceInline" 3) I opt also for not backporting
  16. Raphael Graf uploaded patch set 3 06/19/17, 09:06

  1. TYPO3com voted on patch set 3 V +1 06/19/17, 09:16 Completed build in 09m 24s on Mon, 19 Jun, 11:16 AM Test Summary: 56498 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12680

  2. Henning Liebe uploaded patch set 4 07/17/17, 09:53

  3. TYPO3com voted on patch set 4 V +1 07/17/17, 10:05 Completed build in 11m 26s on Mon, 17 Jul, 12:05 PM Test Summary: 56877 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13293

  4. Frank Nägler voted on patch set 4 CR +1 07/24/17, 07:46

  5. Raphael Graf commented on patch set 4 07/24/17, 11:13

    > Uploaded patch set 4. Patch set 4 does not seem to work for me: Call to undefined method TYPO3\CMS\Core\Page\PageRenderer::createInlineTag()
  6. Susi Moog voted on patch set 4 CR -1 07/24/17, 11:52

  7. Henning Liebe uploaded patch set 5 07/24/17, 13:18

  8. TYPO3com voted on patch set 5 V -1 07/24/17, 13:18 Completed build in 08s on Mon, 24 Jul, 03:18 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13406

  9. Henning Liebe uploaded patch set 6 07/24/17, 13:47

  10. TYPO3com voted on patch set 6 V +1 07/24/17, 13:57 Completed build in 10m 33s on Mon, 24 Jul, 03:57 PM Test Summary: 56913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13407

  11. Jörg Bösche commented on patch set 6 CR +1 V +1 07/25/17, 07:51

    Verified on master (9-dev) with EXT:bootstrap package. IncludeCSS and includeCSSLibs now work with inline syntax.
  12. Wouter Wolters commented on patch set 6 07/25/17, 08:08

    PageRenderer.php:2806

    string and array typehint missing
  13. Jörg Bösche uploaded patch set 7 07/25/17, 08:24

  14. TYPO3com voted on patch set 7 V +1 07/25/17, 08:35 Completed build in 10m 54s on Tue, 25 Jul, 10:35 AM Test Summary: 56916 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13424

  15. Steffen Frese voted on patch set 7 CR +1 07/31/17, 09:28

  16. Christian Müllenhagen commented on patch set 7 08/11/17, 16:18

    PageRenderer.php:2201

    As the else case is duplicated in the renderCssFiles method, wouldn't it be possible to extract this part to a separate method (e.g. createCssTag) an use it in both methods?

    PageRenderer.php:2806

    As described in the change request message, this method creates a css inline tag from the content of a given file. Wouldn't it be better to rename the method name to createInlineCssTagFromFile?
  17. Jörg Bösche uploaded patch set 8 08/14/17, 08:46

  18. Jörg Bösche commented on patch set 7 08/14/17, 08:46

    PageRenderer.php:2201 Reply

    Done

    PageRenderer.php:2806 Reply

    Done
  19. TYPO3com voted on patch set 8 V +1 08/14/17, 08:58 Completed build in 11m 33s on Mon, 14 Aug, 10:58 AM Test Summary: 57432 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13674

  20. Jörg Bösche uploaded patch set 9 08/14/17, 09:20

  21. Henning Liebe voted on patch set 9 CR +1 V +1 08/14/17, 09:44

  22. TYPO3com voted on patch set 9 V -1 08/14/17, 10:21 Completed build in 1h 00m 42s on Mon, 14 Aug, 12:21 PM Test Summary: 138 of 57796 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13677

  23. TYPO3com voted on patch set 9 V +1 08/14/17, 11:04 Completed build in 2h 43m 51s on Mon, 14 Aug, 01:04 PM Test Summary: 57432 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13677

  24. Susi Moog voted on patch set 9 CR +2 V +2 08/14/17, 12:00

  25. Gerrit merged patch set 9 08/14/17, 12:00