Review main Merged

53101[FEATURE] Add duplicate button

Willi Wehmeier CR +2 V +2 Normal +185 −8 updated 02/13/18, 12:24

Commit message

This patch provides a new "duplicate" button inside of the topbar of the
edit record form next to the close button. This button creates and opens
a new copy of the current element which is positioned right below the
existing one.
If there are unsaved changes in the currently open record, a modal
appears with options to cancel, dismiss the changes and clone or save
the changes and clone the changed record.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Anja Leichsenring +1
    • Mathias Schreiber +1
    • Wolfgang Klinger +1
  • Verified V +2
    • Frank Nägler +2
    • Anja Leichsenring +1
    • Mathias Schreiber +1
    • Wolfgang Klinger +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 5068

Show 3043 earlier messages
  1. Willi Wehmeier uploaded patch set 1 06/03/17, 18:35

  2. TYPO3com voted on patch set 1 V -1 06/03/17, 18:42 Completed build in 06m 57s on Sat, 3 Jun, 08:42 PM Test Summary: 2387 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12256

  3. Willi Wehmeier uploaded patch set 2 06/04/17, 09:00

  4. TYPO3com voted on patch set 2 V -1 06/04/17, 09:09 Completed build in 08m 34s on Sun, 4 Jun, 11:09 AM Test Summary: 2334 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12294

  5. Willi Wehmeier uploaded patch set 3 06/04/17, 10:08

  6. TYPO3com voted on patch set 3 V -1 06/04/17, 10:19 Completed build in 10m 19s on Sun, 4 Jun, 12:19 PM Test Summary: 2334 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12309

  7. Willi Wehmeier uploaded patch set 4 06/04/17, 10:36

  8. TYPO3com voted on patch set 4 V -1 06/04/17, 10:44 Completed build in 07m 19s on Sun, 4 Jun, 12:44 PM Test Summary: 2334 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12313

  9. Willi Wehmeier uploaded patch set 5 06/04/17, 11:19

  10. TYPO3com voted on patch set 5 V -1 06/04/17, 11:28 Completed build in 09m 01s on Sun, 4 Jun, 01:28 PM Test Summary: 2334 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12318

  11. Willi Wehmeier uploaded patch set 6 06/04/17, 11:41

  12. TYPO3com voted on patch set 6 V -1 06/04/17, 11:50 Completed build in 08m 41s on Sun, 4 Jun, 01:50 PM Test Summary: 2334 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12321

  13. Oliver Hader uploaded patch set 7 06/04/17, 11:59

  14. TYPO3com voted on patch set 7 V +1 06/04/17, 12:06 Completed build in 07m 29s on Sun, 4 Jun, 02:06 PM Test Summary: 2334 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12325

  15. Georg Ringer commented on patch set 7 06/05/17, 17:34

    please also add a rst file!
  16. Andreas Kienast commented on patch set 7 06/05/17, 19:13

    EditDocumentController.php:175

    Renaming these public attributes is a breaking change.
  17. Willi Wehmeier uploaded patch set 8 06/10/17, 18:14

  18. TYPO3com voted on patch set 8 V +1 06/10/17, 18:24 Completed build in 10m 04s on Sat, 10 Jun, 08:24 PM Test Summary: 56499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12497

  19. Willi Wehmeier commented on patch set 8 06/10/17, 18:26

    > (1 comment) I've reversed the changes to the property names.
  20. Willi Wehmeier commented on patch set 8 06/10/17, 18:27

    > please also add a rst file! rst file is also added.
  21. Josef Glatz commented on patch set 8 06/11/17, 06:35

    A better explaining commit message would also be nice.
  22. Willi Wehmeier updated the commit message in patch set 9 06/11/17, 10:56

  23. Willi Wehmeier commented on patch set 9 06/11/17, 10:57

    > A better explaining commit message would also be nice. Commit message with in detail explanation added.
  24. TYPO3com voted on patch set 9 V +1 06/11/17, 11:06 Completed build in 10m 13s on Sun, 11 Jun, 01:06 PM Test Summary: 56499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12500

  25. Willi Wehmeier uploaded patch set 10 06/11/17, 11:52

  26. Jigal van Hemert commented on patch set 9 CR -1 06/11/17, 11:53

    During a discussion on the dev slack channel we ended up finding a thread on the subject of the save buttons on the decisions platform: https://decisions.typo3.org/t/save-button-solution/77 It seems that only replies to the original question/suggestion were made and that it never came to the voting stage. The current situation with the dropdown save button is not appreciated by enough people to cause two extensions in TER that unroll the select box. With all this in mind I'd like to see a follow up on the decisions platform with a voting at the end to reach a consensus within the community about the desired behaviour of the save button(s) and other buttons. It seems to be a rather important part of the backend UX that affects the productivity of editors with very different use cases and preferences.
  27. TYPO3com voted on patch set 10 V +1 06/11/17, 12:02 Completed build in 09m 48s on Sun, 11 Jun, 02:02 PM Test Summary: 56499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12502

  28. Jigal van Hemert commented on patch set 10 CR -1 06/11/17, 19:49

    During a discussion on the dev slack channel we ended up finding a thread on the subject of the save buttons on the decisions platform: https://decisions.typo3.org/t/save-button-solution/77 It seems that only replies to the original question/suggestion were made and that it never came to the voting stage. The current situation with the dropdown save button is not appreciated by enough people to cause two extensions in TER that unroll the select box. With all this in mind I'd like to see a follow up on the decisions platform with a voting at the end to reach a consensus within the community about the desired behaviour of the save button(s) and other buttons. It seems to be a rather important part of the backend UX that affects the productivity of editors with very different use cases and preferences.
  29. Oliver Hader commented on patch set 10 06/13/17, 17:05

    @Jigal: The discussion about buttons is related to how buttons shall be displayed/unrolled in general. However a possible voting results will be, things might have to be changed afterwards - even without this very change-request. Thus, it does not make sense to block this feature just because there might be a voting some time in the future. We can review and approve this change (if if makes sense besides the unrolling discussion) and adjust the look-and-feel once and if it has been decided upon. Do you agree?
  30. Jigal van Hemert commented on patch set 10 CR 0 06/14/17, 15:02

    > @Jigal: The discussion about buttons is related to how buttons > shall be displayed/unrolled in general. However a possible voting > results will be, things might have to be changed afterwards - even > without this very change-request. > Thus, it does not make sense to block this feature just because > there might be a voting some time in the future. We can review and > approve this change (if if makes sense besides the unrolling > discussion) and adjust the look-and-feel once and if it has been > decided upon. Do you agree? @Oliver: The display/unroll decision also depends on the number of buttons that are available; with enough buttons it's useless to unroll. During development of v7 we talked about the funny "save and delete" button just to indicate that there were already a lot of buttons. It's easy to come up with a lot of other more or less useful buttons (I'll leave out the "save and" bit because there is another discussion about asking what to do with unsaved changes): "translate", "publish", "swap", "move up/down/top/bottom", "cut", "copy", and so on. In my view the whole handling of the buttons in the BE needs a bigger concept. There are many editors with lots of different preferences / requirements. Maybe we decide to accommodate them all and add a lot more buttons, have the current set as default (or only with upgrades), allow integrators to set options which buttons are visible, if there is a dropdown or not. Maybe the "save and" part becomes obsolete once detection of unsaved changes is present in any action (even opening another page, switching modules, logout, etc.); perhaps people like the explicit "save and" part after all. If the duplicate button is approved there is actually no argument against all the other buttons (which are also available as actions elsewhere). Honestly, I've never had the request to have an option to duplicate a page/record/CE during editing of that record. OTOH I think that editors who create bilingual webpages would be happy with a "save and translate" button. As a side note, the description of "-1" is "I would prefer that you didn't submit this". If I read this there is no blocking intention. "-2" is blocking: "Do not submit this". What is your suggestion to vote "I personally do not like this, but if there are enough others in favour it can be merged anyway"? I've set the score to 0 (but still think we should wait with this change until there is a decision on a more complete concept)
  31. Willi Wehmeier uploaded patch set 11 06/16/17, 08:27

  32. TYPO3com voted on patch set 11 V +1 06/16/17, 08:40 Completed build in 12m 39s on Fri, 16 Jun, 10:40 AM Test Summary: 56514 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12612

  33. Mona Muzaffar commented on patch set 11 V -1 06/16/17, 16:35

    when i duplicate an element and then discard it without saving, it still duplicates the element just without the applied changes. when you duplicate a page, you don't see the duplicated page at first since the page tree doesn't reload. After reloading the page tree you see the duplicated pages (might confuse a user)
  34. Willi Wehmeier uploaded patch set 12 06/20/17, 09:45

  35. Willi Wehmeier uploaded patch set 13 06/20/17, 09:49

  36. Willi Wehmeier commented on patch set 13 06/20/17, 09:50

    > when i duplicate an element and then discard it without saving, it > still duplicates the element just without the applied changes. > > when you duplicate a page, you don't see the duplicated page at > first since the page tree doesn't reload. After reloading the page > tree you see the duplicated pages (might confuse a user) I've added a condition that triggers a pagetree reload if the duplicated record is a page.
  37. TYPO3com voted on patch set 12 V +1 06/20/17, 09:57 Completed build in 11m 44s on Tue, 20 Jun, 11:57 AM Test Summary: 56498 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12715

  38. TYPO3com voted on patch set 13 V +1 06/20/17, 10:08 Completed build in 18m 44s on Tue, 20 Jun, 12:08 PM Test Summary: 56498 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12718

  39. Manuel Glauser commented on patch set 13 07/14/17, 20:38

    I'm on it (T3DD coding night)!
  40. Manuel Glauser voted on patch set 13 CR +1 V +1 07/14/17, 21:26

  41. André Stafast commented on patch set 13 07/14/17, 21:29

    I tested it and works normaly, but I except its disabled for example for sys_language table.
  42. Manuel Glauser commented on patch set 13 07/15/17, 07:34

    > I tested it and works normaly, but I except its disabled for > example for sys_language table. Good point. Should it only be enabled for some often used tables by default (i.e. pages, tt_content)? So, we don't force it upon all extensions featuring any kind of records.
  43. Wolfgang Klinger commented on patch set 13 V -1 07/15/17, 13:05

    When I duplicate a page and then click 'cut' on that duplicated page in the page tree it's duplicated again and again and again and …
  1. Reiner Teubner uploaded patch set 14 02/07/18, 11:34

  2. Reiner Teubner commented on patch set 14 V +1 CR +1 02/07/18, 11:42

    Works but it's a little bit confusing when you duplicate a page the frame reload and you automatic edit the new duplicated record. With delays or like a casual user it could be happen you click twice or more and every time a new copy of the copy and so on is generated. I would like to see this feature in the context menu at the page tree -> so the user get feedback if he click copy/cut/duplicate and the context disappear. The result is the same but i am not directly in the editing mode of the page.
  3. TYPO3com voted on patch set 14 V +1 02/07/18, 11:43 Completed build in 08m 45s on Wed, 7 Feb, 12:43 PM Test Summary: 30458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19070

  4. Reiner Teubner commented on patch set 14 02/07/18, 11:44

    Can't reproduce Wolfgangs issue thats it duplicated every time you click the cut button. Intention to touch this patch -> rebase merge conflict.
  5. Anja Leichsenring commented on patch set 14 V +1 CR +1 02/07/18, 20:41

    works for me, nice one. Thank you!
  6. Anja Leichsenring uploaded patch set 15 02/08/18, 20:06

  7. Anja Leichsenring voted on patch set 15 V +1 CR +1 02/08/18, 20:06

  8. TYPO3com voted on patch set 15 V +1 02/08/18, 20:14 Completed build in 08m 16s on Thu, 8 Feb, 09:14 PM Test Summary: 30467 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19164

  9. Anja Leichsenring uploaded patch set 16 02/09/18, 19:19

  10. Anja Leichsenring voted on patch set 16 V +1 CR +1 02/09/18, 19:19

  11. TYPO3com voted on patch set 16 V +1 02/09/18, 19:27 Completed build in 08m 39s on Fri, 9 Feb, 08:27 PM Test Summary: 30470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19213

  12. Wolfgang Klinger commented on patch set 16 V -1 02/10/18, 06:23

    I uploaded a screencast of the mentioned Duplicate+Cut Bug in the forge ticket (77685)
  13. Wolfgang Klinger commented on patch set 16 V 0 02/10/18, 06:24

    And I would like to get an option to disable this button at all.
  14. Mathias Schreiber uploaded patch set 17 02/12/18, 19:37

  15. Mathias Schreiber commented on patch set 17 02/12/18, 19:40

    fixed the reloading issue
  16. TYPO3com voted on patch set 17 V +1 02/12/18, 19:46 Completed build in 08m 54s on Mon, 12 Feb, 08:46 PM Test Summary: 30531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19400

  17. Wolfgang Klinger uploaded patch set 18 02/13/18, 06:54

  18. Wolfgang Klinger commented on patch set 18 V +1 CR +1 02/13/18, 06:56

    I added a FlashMessage::OK to inform the user of the duplication, so that the whole process is more obvious.
  19. TYPO3com voted on patch set 18 V +1 02/13/18, 07:03 Completed build in 08m 51s on Tue, 13 Feb, 08:03 AM Test Summary: 30531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19436

  20. Mathias Schreiber commented on patch set 18 V +1 CR +1 02/13/18, 07:44

    good thinking, Wolfgang
  21. Anja Leichsenring voted on patch set 18 V +1 CR +1 02/13/18, 10:16

  22. Frank Nägler voted on patch set 18 V +1 CR +1 02/13/18, 11:00

  23. Frank Nägler commented on patch set 18 V +2 CR -2 02/13/18, 11:02

    waiting of https://review.typo3.org/#/c/55694/ before this can be merged
  24. Frank Nägler voted on patch set 18 CR +2 02/13/18, 12:22

  25. Frank Nägler merged patch set 19 02/13/18, 12:24