Review TYPO3_8-7 Merged

53112[BUGFIX] Make TemplatePaths->fillDefaultsByPackageName sort paths

Christian Kuhn CR +2 V +2 Normal +101 −35 updated 06/22/17, 15:15

Commit message

Due to the sequence of methods being called from this method,
it is necessary to sort TS-configured paths right when they are
resolved instead of passing the unsorted array further down.

Patch also sorts methods protected below public; true diff is
one line. Toggle this line between before/after and run the test
to see the problem demonstrated.

See issue description for a more detailed reasoning.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 78

  1. Christian Kuhn commented on patch set 1 06/04/17, 09:38

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 06/04/17, 09:49 Completed build in 11m 02s on Sun, 4 Jun, 11:49 AM Test Summary: 56783 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-325

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 06/04/17, 09:52

  4. Gerrit merged patch set 1 06/04/17, 09:52

  5. Xavier Perseguers commented on patch set 2 06/22/17, 14:31

    Post -1 by testing, this breaks File > Filelist when EXT:file_list (frontend plugin) is loaded. See https://forge.typo3.org/issues/81677
  6. Claus Due commented on patch set 2 06/22/17, 15:01

    I'm not entirely sure the filelist vs. file_list is a regression brought on by the patch, but I can see how it would expose the problem. The core of the matter is that in TS terms, there is zero difference between the two keys "file_list" and "filelist", both get mangled to become "filelist" and as such, the TS scopes of those two extensions are already polluting each other. The reported solution *is* the proper safeguard against this problem but I should note that it's only a good solution in this case because "filelist" does not contain any FE plugin that might be affected by clearing the template paths. The cause is as noted on the forge issue and Alexander Grein also pin-points the technical cause. If we change the way this works, it would be an extremely breaking change. So better to recommend avoiding naming so closely to other extensions (because this is a problem between any exts, not just core and community ones).
  7. Claus Due commented on patch set 2 06/22/17, 15:11

  8. Xavier Perseguers commented on patch set 2 06/22/17, 15:15

    I totally agree the naming of EXT:file_list is far from ideal.