53115[BUGFIX] mssql: Identifier quoting and return types
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Anja Leichsenring +1
-
Verified V +2
- Wouter Wolters +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 4
Review log 89
-
Christian Kuhn uploaded patch set 1 06/04/17, 12:54
-
TYPO3com voted on patch set 1 V +1 06/04/17, 13:02 Completed build in 07m 24s on Sun, 4 Jun, 03:02 PM Test Summary: 2334 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12327
-
Wouter Wolters voted on patch set 1 CR +1 06/04/17, 13:30
-
Anja Leichsenring voted on patch set 1 CR +1 V +1 06/05/17, 09:20
-
Wouter Wolters voted on patch set 1 CR +2 V +2 06/05/17, 09:33
-
Gerrit merged patch set 1 06/05/17, 09:33
-
Wouter Wolters commented on patch set 2 06/05/17, 09:33
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 770b0d118523119982e60cf7a330c48b12ba869a -
Tymoteusz Motylewski commented on patch set 2 06/05/17, 10:41
ExpressionBuilder.php:502why couldn't we just cast to string here? -
Christian Kuhn commented on patch set 2 06/06/17, 10:42
ExpressionBuilder.php:502Replythought about that, too. but why should we? if some dbms give us correct types, let's use them. more a benefit to have good data types than a drawback, i'd say.