Review main Abandoned

53117[BUGIFX] Do not respect composer.json package constraints

Helmut Hummel CR 0 V 0 Easy +3 −3 updated 06/05/17, 09:07

Commit message

The PackageManager is only aware of TYPO3 extensions and therefore
must never evaluate any package specified in the composer.json file
as it will never be recognized as available extension.

We now always reset these properties even if there is no correspondent
value set in ext_emconf.php

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 23

  1. Helmut Hummel uploaded patch set 1 06/05/17, 08:19

  2. TYPO3com voted on patch set 1 V +1 06/05/17, 08:27 Completed build in 07m 57s on Mon, 5 Jun, 10:27 AM Test Summary: 2334 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12336

  3. Helmut Hummel abandoned the change 06/05/17, 09:07

    ok, this will work, but is breaking, as composer.json extension requirements are currently respected, but after this change aren't any more