Review TYPO3_8-7 Merged

53118[BUGFIX] mssql: Identifier quoting and return types

Wouter Wolters CR +2 V +2 Normal +77 −15 updated 06/05/17, 09:47

Commit message

Microsoft sql server field & columns quotes quotes identifiers as
[anIdentifier] in comparison to mysql and postgres which quote
with a character that is identical left and right.
The patch adapts some quoting methods to cope with that and
adapts a return type hint where the mssql doctrine driver returns
more precise value types than other platform drivers.

Review

  • Code review CR +2
    • Wouter Wolters +2
  • Verified V +2
    • Wouter Wolters +2
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 34

  1. Wouter Wolters commented on patch set 1 06/05/17, 09:33

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 06/05/17, 09:45 Completed build in 11m 16s on Mon, 5 Jun, 11:45 AM Test Summary: 56807 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-331

  3. Wouter Wolters voted on patch set 1 CR +2 V +2 06/05/17, 09:47

  4. Gerrit merged patch set 1 06/05/17, 09:47