Review main Merged

5312[BUGFIX] Use system locale when indexing external documents

Jigal van Hemert CR +2 V +2 Normal +64 −9 updated 01/18/14, 15:00

Commit message

If paths or filenames of external documents contain utf-8 characters the
system locale must be used. Functions like escapeshellarg and basename are
locale aware.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Markus Klein +1
    • Sebastian Fischer +1
    • Xavier Perseguers +1
  • Verified V +2
    • Stefan Neufeind +2
    • Markus Klein +1

Files 1

Review log 57

Show 32 earlier messages
  1. Georg Ringer commented on patch set 1 05/27/13, 17:19

    (4 inline comments)

    class.external_parser.php:378

    can you remove that line as well?

    class.external_parser.php:384

    space instead of tab

    class.external_parser.php:494

    not 2 tabs

    class.external_parser.php:519

    comment extra line
  2. Jigal van Hemert commented on patch set 1 05/27/13, 17:19

    (3 inline comments)

    class.external_parser.php:378 Reply

    Done

    class.external_parser.php:494 Reply

    Done

    class.external_parser.php:519 Reply

    Done
  3. Oliver Hader uploaded patch set 3 05/27/13, 17:19

  4. Oliver Hader commented on patch set 3 05/27/13, 17:19

    Looks good to me, but someone else must approve Rebasing to master V:0, R:1 V:0, R:1 from Xavier Perseguers <xavier@typo3.org> V:0, R:1 from Georg Ringer <mail@ringerge.org>
  5. Xavier Perseguers commented on patch set 2 05/27/13, 17:19

    Looks good to me, but someone else must approve
  6. Xavier Perseguers commented on patch set 3 05/27/13, 17:19

    Looks good to me, but someone else must approve
  7. Markus Klein uploaded patch set 5 05/27/13, 17:19

  8. Markus Klein commented on patch set 5 05/27/13, 17:19

    Looks good to me, but someone else must approve Update of commit message
  9. Markus Klein commented on patch set 5 05/27/13, 17:19

    @Oliver: Since this is not only used in indexed_search but also stdgraphic and thumbs.php, I suggest committing this as is and creating a followup patch for the code reduction. Any idea where to put this/these functions?
  10. Markus Klein commented on patch set 5 05/27/13, 17:19

    Will you push a new version please.
  11. Markus Klein commented on patch set 5 05/27/13, 17:19

    Jigal just agreed via skype!
  12. Markus Klein uploaded patch set 6 05/27/13, 17:19

  13. Stefan Neufeind commented on patch set 7 4 comments 05/27/13, 17:19

    Looks good to me, but someone else must approve in general looks okay. Just some nitpicks / suggestions.
  14. Markus Klein uploaded patch set 7 05/27/13, 17:19

  15. Markus Klein uploaded patch set 8 05/27/13, 17:19

  16. Markus Klein uploaded patch set 9 05/27/13, 17:19

  17. Stefan Neufeind commented on patch set 10 05/27/13, 17:19

    Looks good to me, but someone else must approve
  18. Markus Klein uploaded patch set 10 05/27/13, 17:19

  19. Oliver Klee commented on patch set 5 05/27/13, 17:19

    Currently, the code duplication occurs only within one class. So let's put the function here (for this issue) and move it later if needed. (The fact that the new code will be needed by other classes is no reason to add new code with lots of duplication in the new code.)
  20. Oliver Klee commented on patch set 5 05/27/13, 17:19

    Will do (if Jigal agrees), but this might take some time.
  21. Oliver Klee commented on patch set 5 05/27/13, 17:19

    At a first glance, the changes look good to me. What to you think about the idea of moving the locale-setting code into a new function to reduce the duplication?
  22. Xavier Perseguers commented on patch set 4 05/27/13, 17:19

    Looks good to me, but someone else must approve Fixed "Releases" line V:0, R:1 V:0, R:1 from Oliver Hader <oliver@typo3.org> V:0, R:1 from Georg Ringer <mail@ringerge.org>
  23. Xavier Perseguers uploaded patch set 4 05/27/13, 17:19

  24. Xavier Perseguers commented on patch set 7 05/27/13, 17:19

    Looks good to me, but someone else must approve
  25. Georg Ringer commented on patch set 2 05/27/13, 17:19

    Looks good to me, but someone else must approve
  26. Jigal van Hemert uploaded patch set 2 05/27/13, 17:19

  27. Philipp Gampe commented on patch set 7 05/27/13, 17:19

    Looks good to me, but someone else must approve
  28. Mattias Nilsson commented on patch set 7 05/27/13, 17:19

    Looks good to me, but someone else must approve
  29. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  30. Mr. Jenkins commented on patch set 2 05/27/13, 17:19

  31. Mr. Jenkins commented on patch set 3 05/27/13, 17:19

  32. Mr. Jenkins commented on patch set 4 05/27/13, 17:19

  1. Mr. Jenkins commented on patch set 5 05/27/13, 17:19

  2. Mr. Jenkins commented on patch set 6 05/27/13, 17:19

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/3734/ : FAILURE
  3. Mr. Jenkins commented on patch set 7 05/27/13, 17:19

  4. Mr. Jenkins commented on patch set 8 05/27/13, 17:19

  5. Mr. Jenkins commented on patch set 9 05/27/13, 17:19

  6. Mr. Jenkins commented on patch set 10 05/27/13, 17:19

  7. Markus Klein uploaded patch set 11 06/13/13, 16:50

  8. Markus Klein commented on patch set 11 CR +1 06/13/13, 16:50

    Rebased for 6.2
  9. Mr. Jenkins commented on patch set 11 06/17/13, 14:14

  10. Markus Klein uploaded patch set 12 07/16/13, 23:07

  11. Mr. Jenkins commented on patch set 12 07/16/13, 23:08

  12. Markus Klein commented on patch set 12 CR +1 07/16/13, 23:08

    Rebased
  13. Markus Klein rebased onto patch set 12 10/15/13, 14:48

  14. Markus Klein voted on patch set 13 CR +1 10/15/13, 14:48

  15. Markus Klein updated the commit message in patch set 13 10/15/13, 14:49

  16. Markus Klein commented on patch set 14 CR +1 10/15/13, 14:49

    removed 4.7 from the cmtmsg
  17. Sebastian Fischer voted on patch set 14 CR +1 1 comment 10/15/13, 14:53

  18. Xavier Perseguers voted on patch set 14 CR +1 10/15/13, 14:58

  19. Mr. Jenkins commented on patch set 13 10/15/13, 21:05

  20. Mr. Jenkins commented on patch set 14 10/15/13, 21:18

  21. Markus Klein commented on patch set 14 V +1 1 comment 11/12/13, 13:37

    This has to be merged finally
  22. Stefan Neufeind commented on patch set 14 CR +1 11/24/13, 20:10

    and 6.1

    FileContentParser.php:460

    no extra indention-tab for >= 6.0

    FileContentParser.php:673

    and maybe inside a if ($lastLocale !== NULL) or so? Just to be safe

    FileContentParser.php:677

    overwrite even if $lastLocale is not yet !== NULL? Or maybe just saving the locale if $lastLocale is NULL (to be safe in case of calling this function twice with param FALSE
  23. Stefan Neufeind commented on patch set 14 V +2 CR +2 1 comment 01/16/14, 23:19

    imho okay like this
  24. Stefan Neufeind merged patch set 15 01/16/14, 23:19

  25. Markus Klein commented on patch set 15 01/18/14, 15:00

    Small regression. The backports are already fixed. Will push a follow up for master.

    FileContentParser.php:665

    backslash missing!

    FileContentParser.php:675

    backslash missing!

    FileContentParser.php:681

    backslash missing!

    FileContentParser.php:682 Reply

    Don't get your question here? What do you want to improve?