5312[BUGFIX] Use system locale when indexing external documents
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Markus Klein +1
- Sebastian Fischer +1
- Xavier Perseguers +1
-
Verified V +2
- Stefan Neufeind +2
- Markus Klein +1
Files 1
Review log 57
Show 32 earlier messages
-
Georg Ringer commented on patch set 1 05/27/13, 17:19
(4 inline comments)class.external_parser.php:378can you remove that line as well?class.external_parser.php:384space instead of tabclass.external_parser.php:494not 2 tabsclass.external_parser.php:519comment extra line -
Jigal van Hemert commented on patch set 1 05/27/13, 17:19
(3 inline comments)class.external_parser.php:378ReplyDoneclass.external_parser.php:494ReplyDoneclass.external_parser.php:519ReplyDone -
Oliver Hader uploaded patch set 3 05/27/13, 17:19
-
Oliver Hader commented on patch set 3 05/27/13, 17:19
Looks good to me, but someone else must approve Rebasing to master V:0, R:1 V:0, R:1 from Xavier Perseguers <xavier@typo3.org> V:0, R:1 from Georg Ringer <mail@ringerge.org> -
Xavier Perseguers commented on patch set 2 05/27/13, 17:19
Looks good to me, but someone else must approve -
Xavier Perseguers commented on patch set 3 05/27/13, 17:19
Looks good to me, but someone else must approve -
Markus Klein uploaded patch set 5 05/27/13, 17:19
-
Markus Klein commented on patch set 5 05/27/13, 17:19
Looks good to me, but someone else must approve Update of commit message -
Markus Klein commented on patch set 5 05/27/13, 17:19
@Oliver: Since this is not only used in indexed_search but also stdgraphic and thumbs.php, I suggest committing this as is and creating a followup patch for the code reduction. Any idea where to put this/these functions? -
Markus Klein commented on patch set 5 05/27/13, 17:19
Will you push a new version please. -
Markus Klein commented on patch set 5 05/27/13, 17:19
Jigal just agreed via skype! -
Markus Klein uploaded patch set 6 05/27/13, 17:19
-
Stefan Neufeind commented on patch set 7 4 comments 05/27/13, 17:19
Looks good to me, but someone else must approve in general looks okay. Just some nitpicks / suggestions. -
Markus Klein uploaded patch set 7 05/27/13, 17:19
-
Markus Klein uploaded patch set 8 05/27/13, 17:19
-
Markus Klein uploaded patch set 9 05/27/13, 17:19
-
Stefan Neufeind commented on patch set 10 05/27/13, 17:19
Looks good to me, but someone else must approve -
Markus Klein uploaded patch set 10 05/27/13, 17:19
-
Oliver Klee commented on patch set 5 05/27/13, 17:19
Currently, the code duplication occurs only within one class. So let's put the function here (for this issue) and move it later if needed. (The fact that the new code will be needed by other classes is no reason to add new code with lots of duplication in the new code.) -
Oliver Klee commented on patch set 5 05/27/13, 17:19
Will do (if Jigal agrees), but this might take some time. -
Oliver Klee commented on patch set 5 05/27/13, 17:19
At a first glance, the changes look good to me. What to you think about the idea of moving the locale-setting code into a new function to reduce the duplication? -
Xavier Perseguers commented on patch set 4 05/27/13, 17:19
Looks good to me, but someone else must approve Fixed "Releases" line V:0, R:1 V:0, R:1 from Oliver Hader <oliver@typo3.org> V:0, R:1 from Georg Ringer <mail@ringerge.org> -
Xavier Perseguers uploaded patch set 4 05/27/13, 17:19
-
Xavier Perseguers commented on patch set 7 05/27/13, 17:19
Looks good to me, but someone else must approve -
Georg Ringer commented on patch set 2 05/27/13, 17:19
Looks good to me, but someone else must approve -
Jigal van Hemert uploaded patch set 2 05/27/13, 17:19
-
Philipp Gampe commented on patch set 7 05/27/13, 17:19
Looks good to me, but someone else must approve -
Mattias Nilsson commented on patch set 7 05/27/13, 17:19
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 05/27/13, 17:19
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1962/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2164/ : SUCCESS -
Mr. Jenkins commented on patch set 3 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2691/ : SUCCESS -
Mr. Jenkins commented on patch set 4 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3567/ : SUCCESS
-
Mr. Jenkins commented on patch set 5 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3707/ : SUCCESS -
Mr. Jenkins commented on patch set 6 05/27/13, 17:19
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/3734/ : FAILURE -
Mr. Jenkins commented on patch set 7 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5624/ : SUCCESS -
Mr. Jenkins commented on patch set 8 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7092/ : SUCCESS -
Mr. Jenkins commented on patch set 9 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7093/ : SUCCESS -
Mr. Jenkins commented on patch set 10 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7094/ : SUCCESS -
Markus Klein uploaded patch set 11 06/13/13, 16:50
-
Markus Klein commented on patch set 11 CR +1 06/13/13, 16:50
Rebased for 6.2 -
Mr. Jenkins commented on patch set 11 06/17/13, 14:14
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9057/ : SUCCESS -
Markus Klein uploaded patch set 12 07/16/13, 23:07
-
Mr. Jenkins commented on patch set 12 07/16/13, 23:08
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9647/ : SUCCESS -
Markus Klein commented on patch set 12 CR +1 07/16/13, 23:08
Rebased -
Markus Klein rebased onto patch set 12 10/15/13, 14:48
-
Markus Klein voted on patch set 13 CR +1 10/15/13, 14:48
-
Markus Klein updated the commit message in patch set 13 10/15/13, 14:49
-
Markus Klein commented on patch set 14 CR +1 10/15/13, 14:49
removed 4.7 from the cmtmsg -
Sebastian Fischer voted on patch set 14 CR +1 1 comment 10/15/13, 14:53
-
Xavier Perseguers voted on patch set 14 CR +1 10/15/13, 14:58
-
Mr. Jenkins commented on patch set 13 10/15/13, 21:05
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11616/ : SUCCESS -
Mr. Jenkins commented on patch set 14 10/15/13, 21:18
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11617/ : SUCCESS -
Markus Klein commented on patch set 14 V +1 1 comment 11/12/13, 13:37
This has to be merged finally -
Stefan Neufeind commented on patch set 14 CR +1 11/24/13, 20:10
and 6.1FileContentParser.php:460no extra indention-tab for >= 6.0FileContentParser.php:673and maybe inside a if ($lastLocale !== NULL) or so? Just to be safeFileContentParser.php:677overwrite even if $lastLocale is not yet !== NULL? Or maybe just saving the locale if $lastLocale is NULL (to be safe in case of calling this function twice with param FALSE -
Stefan Neufeind commented on patch set 14 V +2 CR +2 1 comment 01/16/14, 23:19
imho okay like this -
Stefan Neufeind merged patch set 15 01/16/14, 23:19
-
Markus Klein commented on patch set 15 01/18/14, 15:00
Small regression. The backports are already fixed. Will push a follow up for master.FileContentParser.php:665backslash missing!FileContentParser.php:675backslash missing!FileContentParser.php:681backslash missing!FileContentParser.php:682ReplyDon't get your question here? What do you want to improve?