Review main Merged

53140[BUGFIX] Ensure absolute paths for &eID=dumpFile

Xavier Perseguers CR +2 V +2 Easy +6 −1 updated 08/23/17, 11:08

Commit message

When using realurl (or other extensions modifying the
path of the frontend) then index.php may be linked not
to PATH_site and needs to be taken into account.

Review

  • Code review CR +2
    • Markus Klein +2
    • Stefan Neufeind +1
  • Verified V +2
    • Markus Klein +2
    • Stefan Neufeind +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 3340

Show 1115 earlier messages
  1. Xavier Perseguers uploaded patch set 1 06/06/17, 15:00

  2. Xavier Perseguers commented on patch set 1 CR -1 06/06/17, 15:01

    This is a quick fix but should be fixed more cleanly (thus the "WIP") in message
  3. Markus Klein commented on patch set 1 06/06/17, 15:06

    ResourceStorage.php:1299

    please use a getter for accessing the global
  4. TYPO3com voted on patch set 1 V +1 06/06/17, 15:09 Completed build in 08m 55s on Tue, 6 Jun, 05:09 PM Test Summary: 55386 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12393

  5. Benni Mack uploaded patch set 2 06/15/17, 21:00

  6. TYPO3com voted on patch set 2 V +1 06/15/17, 21:13 Completed build in 13m 04s on Thu, 15 Jun, 11:13 PM Test Summary: 56514 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12608

  7. Xavier Perseguers updated the commit message in patch set 3 06/22/17, 15:01

  8. TYPO3com voted on patch set 3 V -1 06/22/17, 15:16 Completed build in 13m 59s on Thu, 22 Jun, 05:16 PM Test Summary: 1 of 56711 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12784

  9. Xavier Perseguers updated the commit message in patch set 4 06/27/17, 09:46

  10. TYPO3com voted on patch set 4 V +1 06/27/17, 09:57 Completed build in 10m 48s on Tue, 27 Jun, 11:57 AM Test Summary: 56727 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12854

  11. Benni Mack commented on patch set 4 06/27/17, 10:51

    @xavier @markus is this solution fine for you?
  12. Markus Klein commented on patch set 4 CR +1 06/27/17, 12:02

    Makes sense. Thinking about this change a bit more, brings another thing to my mind: This is gonna be heavily breaking! Because we almost always had to work around this issue by prefixing any path retrieved in Fluid with .publicUrl with the absrefprefix manually. So now that we get the API right, we need to undo the manual prefixing! this needs a big and fat warning in the release notes/news etc. But I'm 100% pro this change.
  13. Georg Ringer commented on patch set 4 06/29/17, 10:51

    which means at the same time that this won't be backported... so no 8.7, 7.6
  14. Xavier Perseguers commented on patch set 4 06/29/17, 12:09

    For 7.6 do as you want, but 8.7 is really new so we must change it there as well, most major websites where such a breaking change could be problematic are currently migrating. No way to not fix it in 8.7 at least.
  15. Xavier Perseguers commented on patch set 4 06/29/17, 12:10

    and there are tons of places where you just cannot "just" fix by prefixing a / in the template, I did that at the beginning and found other generated links with invalid path and could not just change a fluid template.
  1. Markus Klein commented on patch set 4 06/29/17, 12:40

    +1 for fixing it in 8.7 too, but add a big fat note everywhere (maillists, t3org news, slack, etc) I'll remind the release team on that once the next version is due.
  2. Xavier Perseguers uploaded patch set 5 07/04/17, 07:24

  3. TYPO3com voted on patch set 5 V +1 07/04/17, 07:34 Completed build in 09m 56s on Tue, 4 Jul, 09:34 AM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12985

  4. Markus Klein commented on patch set 5 07/04/17, 07:58

    ImageService.php:98

    we agreed for the Core to use [] to access characters
  5. Xavier Perseguers uploaded patch set 6 07/04/17, 08:20

  6. TYPO3com voted on patch set 6 V +1 07/04/17, 08:30 Completed build in 09m 58s on Tue, 4 Jul, 10:30 AM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12988

  7. Georg Ringer commented on patch set 6 07/04/17, 17:59

    ImageService.php:98

    I once wrote fal driver which returned urls to different server, so it started with http://. wouldn't this change now change the url to /http:// ?
  8. Xavier Perseguers commented on patch set 6 07/05/17, 06:37

    ImageService.php:98 Reply

    I don't know how this very line could have an effect on your driver but best would be to actually test your own FAL driver with the corresponding patch(es) if you fear something. And then see where the problem is, in your code where you possibly abused something or in the Core missing some key feature for use cases like yours.
  9. Georg Ringer commented on patch set 6 07/05/17, 06:50

    dont have access to that code anymore, but IMO we should just assure that the url does also not start with http:// or https://.
  10. Xavier Perseguers commented on patch set 6 07/05/17, 06:53

    @Georg: Then I guess that what you actually want to say is that we should blank the urlPrefix altogether for such cases. But then this should be the case with actually any scheme because the link could possibly be something else than "http" or "https". e.g., "file" or "ftp". So this would be another test. But... wait... have a look at lines 88-89, it should be exactly your use case, shouldn't it?
  11. Georg Ringer commented on patch set 6 07/05/17, 09:13

    yeah looks good, sorry for the troubles
  12. Xavier Perseguers commented on patch set 6 07/06/17, 08:18

    Maybe we could only fix that on master and 8.7 but NOT 7.6. I insist on backporting to 8.7 since this is a nasty bug which hinders bigger websites and only fixing on master is not an option for the so new 8.7 imho (and I'd likely not have to maintain a fork for a big private bank client).
  13. Markus Klein updated the commit message in patch set 7 07/06/17, 08:19

  14. Markus Klein voted on patch set 7 CR +1 V +1 07/06/17, 08:19

  15. TYPO3com voted on patch set 7 V +1 07/06/17, 08:32 Completed build in 12m 36s on Thu, 6 Jul, 10:32 AM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13034

  16. Stefan Neufeind voted on patch set 7 CR +1 07/06/17, 17:52

  17. Stefan Neufeind commented on patch set 7 V +1 07/06/17, 18:30

    had to verify it on 8.7 here currently (should be the same for master)
  18. Stefan Neufeind commented on patch set 7 07/06/17, 18:31

    maybe for master we might want to provide a feature so eID-urls are configurable somehow?
  19. Markus Klein voted on patch set 7 CR +2 V +2 07/11/17, 10:54

  20. Gerrit merged patch set 7 07/11/17, 10:54

  21. Markus Klein commented on patch set 8 07/11/17, 10:54

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 416a98a3e899cb3a7393cdf346a72076956e0c58
  22. Helmut Hummel commented on patch set 8 07/11/17, 11:32

    post -1 as this introduces a regression when TYPO3 is installed in a sub directory

    ImageService.php:99

    That is broken, when TYPO3 is inside a sub directory and absRefPrefix is configured to be that sub directory. localhost/master/ absRefPrefix = /master/ then the resulting URI will be /master/master/index.php
  23. Helmut Hummel commented on patch set 8 07/11/17, 11:34

    ResourceStorage.php:1297

    we should wrap this in GeneralUtility::locationHeaderUrl() to make sure the final URI contains a scheme and host name. Only then we can be sure that all other code (including TS image URI code) will treat this as final URL
  24. Xavier Perseguers commented on patch set 8 08/23/17, 10:51

    There is another problem, namely when a path to an asset needs to be generated in Backend. This is the case if you try to embed an image within RTE using extension EXT:rte_ckeditor_image. This seems to fix the problem (within ResourceStorage.php): ``` if (TYPO3_MODE === 'FE') { $publicUrl = PathUtility::getAbsoluteWebPath('index.php'); } else { $publicUrl = PathUtility::getAbsoluteWebPath('../index.php'); } $publicUrl .= '?' . http_build_query($queryParameterArray, '', '&', PHP_QUERY_RFC3986); ```
  25. Xavier Perseguers commented on patch set 8 08/23/17, 11:08

    WIP followup patch there: https://review.typo3.org/#/c/53789/