53141[BUGFIX] mssql: ExpressionBuilder inSet() support
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Morton Jonuschat +1
-
Verified V +2
- Markus Klein +2
- Morton Jonuschat +1
- TYPO3com +1 CI
Issues 1
Files 7
- typo3/sysext/core/Classes/Database/Query/Expression/ExpressionBuilder.php+25 −7
- typo3/sysext/core/Tests/Functional/Database/Fixtures/DataSet/TestExpressionBuilderInSet.csvnew+42 −0
- typo3/sysext/core/Tests/Functional/Database/Fixtures/Extensions/test_expressionbuilder/ext_emconf.php1new+22 −0
- typo3/sysext/core/Tests/Functional/Database/Fixtures/Extensions/test_expressionbuilder/ext_tables.sqlnew+13 −0
- typo3/sysext/core/Tests/Functional/Database/Query/Expression/ExpressionBuilderTest.phpnew+399 −0
- typo3/sysext/core/Tests/Unit/Database/Query/Expression/ExpressionBuilderTest.php+46 −0
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbQueryParser.php+1 −1
Review log 1013
-
Christian Kuhn uploaded patch set 1 06/06/17, 16:00
-
TYPO3com voted on patch set 1 V -1 06/06/17, 16:08 Completed build in 07m 38s on Tue, 6 Jun, 06:08 PM Test Summary: 1 of 55425 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12396
-
Christian Kuhn uploaded patch set 2 06/06/17, 17:05
-
TYPO3com voted on patch set 2 V +1 06/06/17, 17:13 Completed build in 07m 41s on Tue, 6 Jun, 07:13 PM Test Summary: 55422 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12399
-
Christian Kuhn commented on patch set 2 06/06/17, 17:19
this fixes ~280 functional tests on mssql. -
Morton Jonuschat voted on patch set 2 CR +1 V +1 06/07/17, 03:14
-
Morton Jonuschat commented on patch set 3 06/07/17, 03:15
Published edit on patch set 2. -
Morton Jonuschat voted on patch set 3 CR +1 V +1 06/07/17, 03:15
-
TYPO3com voted on patch set 3 V +1 06/07/17, 03:23 Completed build in 07m 23s on Wed, 7 Jun, 05:23 AM Test Summary: 55422 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12406
-
Markus Klein voted on patch set 3 CR +2 V +2 06/07/17, 06:25
-
Gerrit merged patch set 3 06/07/17, 06:25
-
Markus Klein commented on patch set 4 06/07/17, 06:25
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 4cb60871a79f00a60bd21d1fe206a549c8f7605d -
Björn Jacob commented on patch set 4 06/07/17, 07:58
Found a small typo. Can be fixed later on ;)ext_emconf.php:12typo: missing "b" ;)