Review main Merged

53141[BUGFIX] mssql: ExpressionBuilder inSet() support

Christian Kuhn CR +2 V +2 Hard +548 −8 updated 06/07/17, 07:58

Commit message

mssql does not support FIND_IN_SET(). The patch adds a
solution based on LIKE.
Since the query fiddling in this area is a bit tricky,
this area is now supported by a bunch of functional tests.
A postgres bug those new functional tests reveal is fixed
along the way.

Review

  • Code review CR +2
    • Markus Klein +2
    • Morton Jonuschat +1
  • Verified V +2
    • Markus Klein +2
    • Morton Jonuschat +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 1013

  1. Christian Kuhn uploaded patch set 1 06/06/17, 16:00

  2. TYPO3com voted on patch set 1 V -1 06/06/17, 16:08 Completed build in 07m 38s on Tue, 6 Jun, 06:08 PM Test Summary: 1 of 55425 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12396

  3. Christian Kuhn uploaded patch set 2 06/06/17, 17:05

  4. TYPO3com voted on patch set 2 V +1 06/06/17, 17:13 Completed build in 07m 41s on Tue, 6 Jun, 07:13 PM Test Summary: 55422 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12399

  5. Christian Kuhn commented on patch set 2 06/06/17, 17:19

    this fixes ~280 functional tests on mssql.
  6. Morton Jonuschat voted on patch set 2 CR +1 V +1 06/07/17, 03:14

  7. Morton Jonuschat commented on patch set 3 06/07/17, 03:15

    Published edit on patch set 2.
  8. Morton Jonuschat voted on patch set 3 CR +1 V +1 06/07/17, 03:15

  9. TYPO3com voted on patch set 3 V +1 06/07/17, 03:23 Completed build in 07m 23s on Wed, 7 Jun, 05:23 AM Test Summary: 55422 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12406

  10. Markus Klein voted on patch set 3 CR +2 V +2 06/07/17, 06:25

  11. Gerrit merged patch set 3 06/07/17, 06:25

  12. Markus Klein commented on patch set 4 06/07/17, 06:25

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 4cb60871a79f00a60bd21d1fe206a549c8f7605d
  13. Björn Jacob commented on patch set 4 06/07/17, 07:58

    Found a small typo. Can be fixed later on ;)

    ext_emconf.php:12

    typo: missing "b" ;)