Review TYPO3_8-7 Merged

53147[BUGFIX] mssql: ExpressionBuilder inSet() support

Markus Klein CR +2 V +2 Hard +548 −8 updated 06/07/17, 08:29

Commit message

mssql does not support FIND_IN_SET(). The patch adds a
solution based on LIKE.
Since the query fiddling in this area is a bit tricky,
this area is now supported by a bunch of functional tests.
A postgres bug those new functional tests reveal is fixed
along the way.

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 34

  1. Markus Klein commented on patch set 1 06/07/17, 06:25

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 06/07/17, 06:35 Completed build in 09m 20s on Wed, 7 Jun, 08:35 AM Test Summary: 56843 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-348

  3. Markus Klein voted on patch set 1 CR +2 V +2 06/07/17, 08:29

  4. Gerrit merged patch set 1 06/07/17, 08:29