Review TYPO3_7-6 Merged

53148[BUGFIX] Detect upper limit of database server version

Markus Klein CR +2 V +2 Easy +37 −9 updated 06/07/17, 14:09

Commit message

Review

  • Code review CR +2
    • Alexander Opitz +2
    • Johannes Kasberger +1
  • Verified V +2
    • Alexander Opitz +2
    • Johannes Kasberger +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 912

  1. Markus Klein uploaded patch set 1 06/07/17, 08:51

  2. TYPO3com voted on patch set 1 V +1 06/07/17, 08:57 Completed build in 05m 42s on Wed, 7 Jun, 10:57 AM Test Summary: 38592 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-955

  3. Johannes Kasberger commented on patch set 1 CR +1 V +1 06/07/17, 09:01

    Tested the patch with mariadb 10.2 and 10.1 and it correctly reports 10.2 as unsupported.
  4. Alexander Opitz commented on patch set 1 06/07/17, 10:04

    Backport for 6.2?

    DatabaseCheck.php:98

    I would let this var stay where it was, it is used in if and else with same value.
  5. Markus Klein uploaded patch set 2 06/07/17, 11:34

  6. Markus Klein uploaded patch set 3 06/07/17, 11:35

  7. Johannes Kasberger voted on patch set 3 CR +1 V +1 06/07/17, 11:39

  8. TYPO3com voted on patch set 2 V +1 06/07/17, 11:40 Completed build in 05m 34s on Wed, 7 Jun, 01:40 PM Test Summary: 38592 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-956

  9. TYPO3com voted on patch set 3 V +1 06/07/17, 11:44 Completed build in 08m 24s on Wed, 7 Jun, 01:44 PM Test Summary: 38592 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-957

  10. Alexander Opitz voted on patch set 3 CR +2 06/07/17, 12:02

  11. Alexander Opitz voted on patch set 3 V +2 06/07/17, 14:09

  12. Gerrit merged patch set 3 06/07/17, 14:09