Review main Merged

53153[BUGFIX] mssql: ext:impexp test fixes

Christian Kuhn CR +2 V +2 Nightmare +5380 −4 updated 06/07/17, 13:49

Commit message

The patch adds fixture comparison files
for mssql platform on ext:impexp functional
tests.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Jan Helke +1
  • Verified V +2
    • Frank Nägler +2
    • Jan Helke +1
    • TYPO3com +1 CI

Issues 1

Files 12

Review log 67

  1. Christian Kuhn uploaded patch set 1 06/07/17, 13:18

  2. Christian Kuhn commented on patch set 1 06/07/17, 13:20

    ext_emconf.php:12

    drive-by typo fix ;)

    tx_impexpgroupfiles_item.php:16

    field exists in db, so it should be registered in ['ctrl'] section, too for dataHandler auto-typing.

    IrreTutorialRecordsTest.php:2

    drive-by fix: wrong namespace

    PagesAndTtContentWithImagesInEmptyDatabaseTest.php:2

    drive-by fix: wrong namespace
  3. TYPO3com voted on patch set 1 V +1 06/07/17, 13:26 Completed build in 07m 44s on Wed, 7 Jun, 03:26 PM Test Summary: 55422 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12423

  4. Jan Helke voted on patch set 1 CR +1 V +1 06/07/17, 13:26

  5. Frank Nägler voted on patch set 1 CR +2 V +2 06/07/17, 13:48

  6. Gerrit merged patch set 1 06/07/17, 13:48

  7. Frank Nägler commented on patch set 2 06/07/17, 13:49

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit a88dd246768290e8fed64286a9b5e97c74439ca4