Review main Merged

53160[TASK] Remove CSH of ancient form wizard

Georg Ringer CR +2 V +2 Normal +1 −78 updated 06/09/17, 14:27

Commit message

The first form wizard is not there anymore, therefore the
CSH must be removed as well.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 1215

  1. Georg Ringer uploaded patch set 1 06/07/17, 14:32

  2. TYPO3com voted on patch set 1 V +1 06/07/17, 14:44 Completed build in 12m 05s on Wed, 7 Jun, 04:44 PM Test Summary: 56511 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12431

  3. Björn Jacob commented on patch set 1 CR +1 V +1 06/08/17, 05:28

    Thx for the cleanup. Commit msg is fine with me but how about "Remove CSH of ancient form wizard" or "first"? Does not look like a typo though.
  4. Georg Ringer updated the commit message in patch set 2 06/08/17, 07:04

  5. TYPO3com voted on patch set 2 V +1 06/08/17, 07:14 Completed build in 10m 18s on Thu, 8 Jun, 09:14 AM Test Summary: 56511 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12454

  6. Wouter Wolters voted on patch set 2 CR +1 06/08/17, 07:15

  7. Björn Jacob commented on patch set 2 CR +1 V +1 06/08/17, 07:57

    :)
  8. Christian Kuhn commented on patch set 2 CR -1 06/08/17, 13:19

    locallang_csh_corebe.xlf:823

    it seems the wizard_form_wiz keys are still referenced in sysext/frontend/Resources/Private/Language/locallang_csh_ttcontent.xlf

    locallang_csh_corebe.xlf:877

    i think the wizard_table_wiz keys belong to the table wizard (not the old forms wizard). and they are still referenced in sysext/backend/Classes/Controller/Wizard/TableController.php
  9. Georg Ringer uploaded patch set 3 06/08/17, 17:18

  10. TYPO3com voted on patch set 3 V +1 06/08/17, 17:29 Completed build in 10m 04s on Thu, 8 Jun, 07:29 PM Test Summary: 56511 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12462

  11. Christian Kuhn voted on patch set 3 CR +1 V +1 06/09/17, 14:24

  12. Wouter Wolters voted on patch set 3 CR +1 06/09/17, 14:26

  13. Anja Leichsenring voted on patch set 3 CR +1 V +1 06/09/17, 14:26

  14. Christian Kuhn voted on patch set 3 CR +2 V +2 06/09/17, 14:27

  15. Gerrit merged patch set 3 06/09/17, 14:27