Review main Merged

53180[TASK] Merge EXT:cshmanual into EXT:documentation

Georg Ringer CR +2 V +2 Hard +248 −506 updated 09/30/17, 20:17

Commit message

To reduce the amount of system extensions the extension
cshmanual can be merged into EXT:documentation.

Review

  • Code review CR +2
    • Benni Mack +2
    • Mona Muzaffar +1
  • Verified V +2
    • Benni Mack +2
    • Mona Muzaffar +1
    • TYPO3com +1 CI

Issues 1

Files 32

Show 12 more files

Review log 1624

  1. Georg Ringer uploaded patch set 1 06/09/17, 19:19

  2. Georg Ringer rebased onto patch set 2 06/14/17, 11:44

  3. Georg Ringer uploaded patch set 3 06/14/17, 11:54

  4. TYPO3com voted on patch set 3 V -1 06/14/17, 12:07 Completed build in 13m 22s on Wed, 14 Jun, 02:07 PM Test Summary: 56499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12568

  5. Benni Mack uploaded patch set 4 06/14/17, 16:21

  6. TYPO3com voted on patch set 4 V +1 06/14/17, 16:31 Completed build in 10m 18s on Wed, 14 Jun, 06:31 PM Test Summary: 56514 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12580

  7. Georg Ringer uploaded patch set 5 07/14/17, 19:05

  8. TYPO3com voted on patch set 5 V -1 07/14/17, 19:05 Completed build in 11s on Fri, 14 Jul, 09:05 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13183

  9. Georg Ringer uploaded patch set 6 07/14/17, 19:08

  10. TYPO3com voted on patch set 6 V -1 07/14/17, 19:44 Completed build in 36m 06s on Fri, 14 Jul, 09:44 PM Test Summary: 12 of 1302 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13184

  11. Georg Ringer uploaded patch set 7 09/22/17, 18:00

  12. TYPO3com voted on patch set 7 V +1 09/22/17, 18:13 Completed build in 13m 23s on Fri, 22 Sep, 08:13 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15128

  13. Helmut Hummel commented on patch set 7 09/23/17, 08:35

    composer.json:30

    cshmanual was part of minimal usable system. merging it into documentation, makes this extension part of minimal usable system, too Not sure if this is really what we want.
  14. Benni Mack commented on patch set 7 CR -1 09/26/17, 04:25

    ContextHelp.js:44

    should be removed?

    LegacyClassesForIde.php:13

    why do you remove the old class aliases?

    composer.json:30 Reply

    Agreed, the main restriction is that (currently EXT:backend) has a dependency via JS calling the cshmanual API. This should be migrated and then IMHO EXT:documentation should not be part of the minimum usable system anymore.

    LegacyClassesForIde.php:16

    ah, so this is mixed up with the other file - should be switched.

    BackendUserMergeAboutModules.php:22

    This upgrade wizard should migrate the cshmanual_* BE module
  15. Georg Ringer uploaded patch set 8 09/26/17, 05:36

  16. TYPO3com voted on patch set 8 V +1 09/26/17, 05:51 Completed build in 15m 14s on Tue, 26 Sep, 07:51 AM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15145

  17. Mona Muzaffar voted on patch set 8 V +1 09/27/17, 19:06

  18. Benni Mack uploaded patch set 9 09/30/17, 19:43

  19. Benni Mack voted on patch set 9 CR +1 V +1 09/30/17, 19:44

  20. TYPO3com voted on patch set 9 V -1 09/30/17, 19:56 Completed build in 12m 55s on Sat, 30 Sep, 09:56 PM Test Summary: 1 of 57123 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15226

  21. Mona Muzaffar voted on patch set 9 CR +1 V +1 09/30/17, 19:57

  22. TYPO3com voted on patch set 9 V +1 09/30/17, 20:03 Completed build in 32m 25s on Sat, 30 Sep, 10:03 PM Test Summary: 56764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15226

  23. Benni Mack voted on patch set 9 CR +2 V +2 09/30/17, 20:17

  24. Gerrit merged patch set 9 09/30/17, 20:17