53180[TASK] Merge EXT:cshmanual into EXT:documentation
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Mona Muzaffar +1
-
Verified V +2
- Benni Mack +2
- Mona Muzaffar +1
- TYPO3com +1 CI
Issues 1
Files 32
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ContextHelp.js1+2 −2
- typo3/sysext/core/Documentation/Changelog/master/Important-81574-MergedSystemExtensionCshmanualIntoDocumentation.rstnew+17 −0
- typo3/sysext/core/Tests/Acceptance/Backend/Extensionmanager/InstalledExtensionsCest.php+2 −2
- typo3/sysext/cshmanual/Resources/Private/Partials/TableOfContents.htmldeleted+0 −35
- typo3/sysext/cshmanual/Resources/Private/Templates/Help/Index.htmldeleted+0 −13
- typo3/sysext/cshmanual/Resources/Public/Icons/Extension.pngdeletedbinary
- typo3/sysext/cshmanual/composer.json2deleted+0 −40
- typo3/sysext/cshmanual/ext_emconf.phpdeleted+0 −21
- typo3/sysext/cshmanual/ext_tables.phpdeleted+0 −21
- typo3/sysext/cshmanual/LICENSE.txtdeleted+0 −345
- typo3/sysext/documentation/Classes/Controller/HelpController.phprenamed+2 −2
- typo3/sysext/documentation/Classes/Domain/Repository/TableManualRepository.phprenamed+5 −5
- typo3/sysext/documentation/Classes/Service/AccessService.phprenamed+1 −1
- typo3/sysext/documentation/Classes/Service/JavaScriptService.phprenamed+3 −3
- typo3/sysext/documentation/Migrations/Code/ClassAliasMap.phpnew+6 −0
- typo3/sysext/documentation/Migrations/Code/LegacyClassesForIde.php1new+22 −0
- typo3/sysext/documentation/Resources/Private/Language/locallang_mod_help_cshmanual.xlfrenamed+0 −0
- typo3/sysext/documentation/Resources/Private/Language/locallang_view_help.xlfrenamed+0 −0
- typo3/sysext/documentation/Resources/Private/Layouts/ContextSensitiveHelp.htmlrenamed+0 −0
Show 12 more files
- typo3/sysext/documentation/Resources/Private/Partials/Manual.htmlrenamed+3 −3
- typo3/sysext/documentation/Resources/Private/Partials/TableOfContents.htmlnew+35 −0
- typo3/sysext/documentation/Resources/Private/Templates/Help/All.htmlrenamed+3 −3
- typo3/sysext/documentation/Resources/Private/Templates/Help/Detail.htmlrenamed+2 −3
- typo3/sysext/documentation/Resources/Private/Templates/Help/Index.htmlnew+12 −0
- typo3/sysext/documentation/Resources/Public/Icons/module-cshmanual.svgrenamed+0 −0
- typo3/sysext/documentation/composer.json+10 −3
- typo3/sysext/documentation/ext_tables.php+17 −0
- typo3/sysext/install/Classes/Updates/BackendUserStartModuleUpdate.phpnew+101 −0
- typo3/sysext/install/ext_localconf.php+2 −0
- composer.json+1 −2
- composer.lock+1 −1
Review log 1624
-
Georg Ringer uploaded patch set 1 06/09/17, 19:19
-
Georg Ringer rebased onto patch set 2 06/14/17, 11:44
-
Georg Ringer uploaded patch set 3 06/14/17, 11:54
-
TYPO3com voted on patch set 3 V -1 06/14/17, 12:07 Completed build in 13m 22s on Wed, 14 Jun, 02:07 PM Test Summary: 56499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12568
-
Benni Mack uploaded patch set 4 06/14/17, 16:21
-
TYPO3com voted on patch set 4 V +1 06/14/17, 16:31 Completed build in 10m 18s on Wed, 14 Jun, 06:31 PM Test Summary: 56514 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12580
-
Georg Ringer uploaded patch set 5 07/14/17, 19:05
-
TYPO3com voted on patch set 5 V -1 07/14/17, 19:05 Completed build in 11s on Fri, 14 Jul, 09:05 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13183
-
Georg Ringer uploaded patch set 6 07/14/17, 19:08
-
TYPO3com voted on patch set 6 V -1 07/14/17, 19:44 Completed build in 36m 06s on Fri, 14 Jul, 09:44 PM Test Summary: 12 of 1302 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13184
-
Georg Ringer uploaded patch set 7 09/22/17, 18:00
-
TYPO3com voted on patch set 7 V +1 09/22/17, 18:13 Completed build in 13m 23s on Fri, 22 Sep, 08:13 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15128
-
Helmut Hummel commented on patch set 7 09/23/17, 08:35
-
Benni Mack commented on patch set 7 CR -1 09/26/17, 04:25
ContextHelp.js:44should be removed?LegacyClassesForIde.php:13why do you remove the old class aliases?composer.json:30ReplyAgreed, the main restriction is that (currently EXT:backend) has a dependency via JS calling the cshmanual API. This should be migrated and then IMHO EXT:documentation should not be part of the minimum usable system anymore.LegacyClassesForIde.php:16ah, so this is mixed up with the other file - should be switched.BackendUserMergeAboutModules.php:22This upgrade wizard should migrate the cshmanual_* BE module -
Georg Ringer uploaded patch set 8 09/26/17, 05:36
-
TYPO3com voted on patch set 8 V +1 09/26/17, 05:51 Completed build in 15m 14s on Tue, 26 Sep, 07:51 AM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15145
-
Mona Muzaffar voted on patch set 8 V +1 09/27/17, 19:06
-
Benni Mack uploaded patch set 9 09/30/17, 19:43
-
Benni Mack voted on patch set 9 CR +1 V +1 09/30/17, 19:44
-
TYPO3com voted on patch set 9 V -1 09/30/17, 19:56 Completed build in 12m 55s on Sat, 30 Sep, 09:56 PM Test Summary: 1 of 57123 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15226
-
Mona Muzaffar voted on patch set 9 CR +1 V +1 09/30/17, 19:57
-
TYPO3com voted on patch set 9 V +1 09/30/17, 20:03 Completed build in 32m 25s on Sat, 30 Sep, 10:03 PM Test Summary: 56764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15226
-
Benni Mack voted on patch set 9 CR +2 V +2 09/30/17, 20:17
-
Gerrit merged patch set 9 09/30/17, 20:17
composer.json:30