53181[BUGFIX] Allow RTE yml presets in LocalConfiguration
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Josef Glatz +1
- Georg Ringer +1
- Frans Saris +1
-
Verified V +2
- Benni Mack +2
- Josef Glatz +1
- Georg Ringer +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1114
-
Christian Kuhn uploaded patch set 1 06/09/17, 21:44
-
Christian Kuhn updated the commit message in patch set 2 06/09/17, 21:45
-
TYPO3com voted on patch set 2 V +1 06/09/17, 21:59 Completed build in 14m 22s on Fri, 9 Jun, 11:59 PM Test Summary: 56499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12490
-
TYPO3com voted on patch set 1 V -1 06/09/17, 22:10 Completed build in 26m 00s on Sat, 10 Jun, 12:10 AM Test Summary: 1 of 56501 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12489
-
Markus Klein commented on patch set 2 06/09/17, 23:14
how can that happen? if the ext dependencies are correct, your ext is loaded afterwards. And I assume you do the configuration changes in the same file as the core ext does, ext_tables -
Christian Kuhn commented on patch set 2 06/09/17, 23:19
nah. the scenario is: i set something like $GLOBALS['TYPO3_CONF_VARS']['RTE']['Presets']['default'] = 'EXT:rte_ckeditor/Configuration/RTE/Full.yaml in LocalConfiguration / AdditionalConfiguration. ext_tables files are loaded after LocalConfiguration / AdditionalConfiguration, so it currently just resets any previously set default configuration. The patch takes care ext_tables.php of rte_ckeditor just sets config if there isn't any, yet. -
Christian Kuhn updated the commit message in patch set 3 06/09/17, 23:44
-
TYPO3com voted on patch set 3 V +1 06/09/17, 23:56 Completed build in 12m 38s on Sat, 10 Jun, 01:56 AM Test Summary: 56499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12492
-
Frans Saris voted on patch set 3 CR +1 06/10/17, 14:57
-
Georg Ringer voted on patch set 3 CR +1 V +1 06/10/17, 17:35
-
Josef Glatz voted on patch set 3 CR +1 V +1 06/10/17, 20:29
-
Benni Mack voted on patch set 3 CR +2 V +2 06/12/17, 12:47
-
Gerrit merged patch set 3 06/12/17, 12:47
-
Benni Mack commented on patch set 4 06/12/17, 12:47
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit ffaef8cf9076882fb2a8de80f81acbc27a8d3eea