Review main Merged

53183[TASK] change intval() to (int)

anonymized-61094 CR +2 V +2 Easy +5 −5 updated 06/12/17, 09:24

Commit message

Typecasting with (int) is about 2-3 times faster than using intval().

Review

  • Code review CR +2
    • Georg Ringer +2
    • Josef Glatz +1
    • Wouter Wolters +1
  • Verified V +2
    • Georg Ringer +2
    • Josef Glatz +1
    • Wouter Wolters +1

Issues 1

Files 3

Review log 1214

  1. anonymized-61094 uploaded patch set 1 06/10/17, 22:37

  2. TYPO3com voted on patch set 1 V +1 06/10/17, 22:47 Completed build in 10m 14s on Sun, 11 Jun, 12:47 AM Test Summary: 56499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12498

  3. Oliver Klee voted on patch set 1 CR +1 06/10/17, 23:36

  4. Josef Glatz voted on patch set 1 CR +1 06/11/17, 06:33

  5. Sascha Egerer voted on patch set 1 CR +1 06/11/17, 17:51

  6. Georg Ringer voted on patch set 1 CR +1 V +1 06/12/17, 07:13

  7. Wouter Wolters commented on patch set 1 CR -1 06/12/17, 09:09

    needs a proper forge ticket, will create a new one.
  8. Wouter Wolters updated the commit message in patch set 2 06/12/17, 09:09

  9. Wouter Wolters voted on patch set 2 CR +1 V +1 06/12/17, 09:10

  10. Josef Glatz voted on patch set 2 CR +1 V +1 06/12/17, 09:10

  11. Georg Ringer voted on patch set 2 CR +2 V +2 06/12/17, 09:12

  12. Gerrit merged patch set 2 06/12/17, 09:12

  13. Georg Ringer commented on patch set 3 06/12/17, 09:12

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit c05b56b0ab151ed1bbd72bf0b01a7111e6ac38dd
  14. TYPO3com commented on patch set 2 06/12/17, 09:24 Completed build in 14m 38s on Mon, 12 Jun, 11:24 AM Test Summary: 56499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12516