Review main Merged

53185[TASK] Deprecate DocumentTemplate::formWidth()

Georg Ringer CR +2 V +2 Normal +46 −19 updated 06/17/17, 19:24

Commit message

The method DocumentTemplate::formWidth() is not needed anymore as
the styling can be done by using bootstrap and regular CSS classes.

Review

  • Code review CR +2
    • Benni Mack +2
    • Frank Nägler +1
  • Verified V +2
    • Benni Mack +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 79

  1. Georg Ringer uploaded patch set 1 06/11/17, 17:00

  2. TYPO3com voted on patch set 1 V -1 06/11/17, 17:10 Completed build in 09m 53s on Sun, 11 Jun, 07:10 PM Test Summary: 56499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12508

  3. Benni Mack uploaded patch set 2 06/12/17, 19:23

  4. TYPO3com voted on patch set 2 V +1 06/12/17, 19:35 Completed build in 12m 08s on Mon, 12 Jun, 09:35 PM Test Summary: 56499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12532

  5. Benni Mack voted on patch set 2 CR +1 06/15/17, 19:49

  6. Markus Klein commented on patch set 2 06/16/17, 08:57

    We should add the inline styles directly where we remove the calls to this method.
  7. Frank Nägler voted on patch set 2 CR +1 V +1 06/17/17, 15:02

  8. Benni Mack voted on patch set 2 CR +2 V +2 06/17/17, 19:24

  9. Gerrit merged patch set 2 06/17/17, 19:24