53188[BUGFIX] Better documentation of cObject viewhelper
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Robert Wildling +1
-
Verified V +2
- Wouter Wolters +2
- Robert Wildling +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1822
-
Markus Klein uploaded patch set 1 06/12/17, 09:34
-
Wouter Wolters commented on patch set 1 06/12/17, 09:39
-
TYPO3com voted on patch set 1 V +1 06/12/17, 09:45 Completed build in 10m 42s on Mon, 12 Jun, 11:45 AM Test Summary: 56499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12518
-
Markus Klein commented on patch set 2 06/12/17, 13:45
Published edit on patch set 1. -
TYPO3com voted on patch set 2 V +1 06/12/17, 13:58 Completed build in 12m 23s on Mon, 12 Jun, 03:58 PM Test Summary: 56499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12524
-
Wouter Wolters voted on patch set 2 CR +1 06/12/17, 14:03
-
Benni Mack voted on patch set 2 CR +1 V +1 06/12/17, 15:32
-
Benni Mack commented on patch set 2 06/12/17, 15:32
Please merge directly, no change in behaviour. -
Markus Klein commented on patch set 2 06/12/17, 16:11
Waiting for the votes of the original "reporter" of the issue. -
Georg Ringer voted on patch set 2 CR +1 V +1 06/12/17, 18:11
-
Claus Due commented on patch set 3 06/13/17, 10:47
Published edit on patch set 2. -
Claus Due commented on patch set 3 06/13/17, 10:47
Edited for syntax and readability. -
Claus Due commented on patch set 3 06/13/17, 10:49
CObjectViewHelper.php:111If someone familiar with rendering "FILES" ts objects would verify this that would be great. -
TYPO3com voted on patch set 3 V +1 06/13/17, 10:58 Completed build in 10m 34s on Tue, 13 Jun, 12:58 PM Test Summary: 56499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12544
-
Markus Klein commented on patch set 3 06/13/17, 11:13
CObjectViewHelper.php:111ReplyI did, since I crawled the source code, where the tablename is actualyl used -
Markus Klein commented on patch set 3 CR -1 06/13/17, 11:15
CObjectViewHelper.php:111Replyehm, Claus. Nope, that is simply wrong! you never set that to sys_file_reference, you set that to the table the data stems from! Hence, the table that is referenced in the sys_file_references. Eg. tt_content -
Markus Klein commented on patch set 4 06/13/17, 11:17
Published edit on patch set 3. -
TYPO3com voted on patch set 4 V +1 06/13/17, 11:27 Completed build in 10m 02s on Tue, 13 Jun, 01:27 PM Test Summary: 56499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12546
-
Robert Wildling voted on patch set 4 CR +1 V +1 06/15/17, 08:10
-
Wouter Wolters voted on patch set 4 CR +2 V +2 06/15/17, 08:12
-
Gerrit merged patch set 4 06/15/17, 08:12
-
Wouter Wolters commented on patch set 5 06/15/17, 08:13
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 9f2c5b4d982b437bd8b9d711f7fceaba8d7e614f
CObjectViewHelper.php:111