Review main Merged

53188[BUGFIX] Better documentation of cObject viewhelper

Markus Klein CR +2 V +2 Easy +1 −1 updated 06/15/17, 08:13

Commit message

Add more information about the table argument and when it should
be set.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Robert Wildling +1
  • Verified V +2
    • Wouter Wolters +2
    • Robert Wildling +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1822

  1. Markus Klein uploaded patch set 1 06/12/17, 09:34

  2. Wouter Wolters commented on patch set 1 06/12/17, 09:39

    CObjectViewHelper.php:111

    this should be set minus the "is"
  3. TYPO3com voted on patch set 1 V +1 06/12/17, 09:45 Completed build in 10m 42s on Mon, 12 Jun, 11:45 AM Test Summary: 56499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12518

  4. Markus Klein commented on patch set 2 06/12/17, 13:45

    Published edit on patch set 1.
  5. TYPO3com voted on patch set 2 V +1 06/12/17, 13:58 Completed build in 12m 23s on Mon, 12 Jun, 03:58 PM Test Summary: 56499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12524

  6. Wouter Wolters voted on patch set 2 CR +1 06/12/17, 14:03

  7. Benni Mack voted on patch set 2 CR +1 V +1 06/12/17, 15:32

  8. Benni Mack commented on patch set 2 06/12/17, 15:32

    Please merge directly, no change in behaviour.
  9. Markus Klein commented on patch set 2 06/12/17, 16:11

    Waiting for the votes of the original "reporter" of the issue.
  10. Georg Ringer voted on patch set 2 CR +1 V +1 06/12/17, 18:11

  11. Claus Due commented on patch set 3 06/13/17, 10:47

    Published edit on patch set 2.
  12. Claus Due commented on patch set 3 06/13/17, 10:47

    Edited for syntax and readability.
  13. Claus Due commented on patch set 3 06/13/17, 10:49

    CObjectViewHelper.php:111

    If someone familiar with rendering "FILES" ts objects would verify this that would be great.
  14. TYPO3com voted on patch set 3 V +1 06/13/17, 10:58 Completed build in 10m 34s on Tue, 13 Jun, 12:58 PM Test Summary: 56499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12544

  15. Markus Klein commented on patch set 3 06/13/17, 11:13

    CObjectViewHelper.php:111 Reply

    I did, since I crawled the source code, where the tablename is actualyl used
  16. Markus Klein commented on patch set 3 CR -1 06/13/17, 11:15

    CObjectViewHelper.php:111 Reply

    ehm, Claus. Nope, that is simply wrong! you never set that to sys_file_reference, you set that to the table the data stems from! Hence, the table that is referenced in the sys_file_references. Eg. tt_content
  17. Markus Klein commented on patch set 4 06/13/17, 11:17

    Published edit on patch set 3.
  18. TYPO3com voted on patch set 4 V +1 06/13/17, 11:27 Completed build in 10m 02s on Tue, 13 Jun, 01:27 PM Test Summary: 56499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12546

  19. Robert Wildling voted on patch set 4 CR +1 V +1 06/15/17, 08:10

  20. Wouter Wolters voted on patch set 4 CR +2 V +2 06/15/17, 08:12

  21. Gerrit merged patch set 4 06/15/17, 08:12

  22. Wouter Wolters commented on patch set 5 06/15/17, 08:13

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 9f2c5b4d982b437bd8b9d711f7fceaba8d7e614f