53198[!!!][TASK] Use protocol in pages.url and migrate pages.urltype
Commit message
Review
-
Code review CR +2
- Andreas Kienast +2
- Georg Ringer +1
-
Verified V +2
- Andreas Kienast +2
- Georg Ringer +1
- TYPO3com +1 CI
Issues 1
Files 15
- typo3/sysext/core/Configuration/TCA/pages.php+1 −31
- typo3/sysext/core/Documentation/Changelog/master/Breaking-71306-DroppedProtocolFieldFromPageTypeLinkToExternalURL.rstnew+51 −0
- typo3/sysext/core/Resources/Private/Language/locallang_csh_pages.xlf+1 −9
- typo3/sysext/core/Tests/Functional/Tca/PagesVisibleFieldsTest.php+0 −1
- typo3/sysext/core/ext_tables.sql+0 −1
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+5 −5
- typo3/sysext/frontend/Classes/Page/PageRepository.php+11 −12
- typo3/sysext/frontend/Configuration/TCA/pages_language_overlay.php+1 −11
- typo3/sysext/frontend/Resources/Private/Language/locallang_tca.xlf+0 −3
- typo3/sysext/frontend/Tests/Functional/Tca/PagesLanguageOverlayVisibleFieldsTest.php+0 −1
- typo3/sysext/frontend/Tests/Unit/Page/PageRepositoryTest.php+36 −5
- typo3/sysext/frontend/ext_tables.sql+0 −1
- typo3/sysext/install/Classes/Updates/MigrateUrlTypesInPagesUpdate.phpnew+154 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyPublicMatcher.php+5 −0
- typo3/sysext/install/ext_localconf.php1+2 −0
Review log 1528
Show 23 earlier messages
-
Benni Mack uploaded patch set 1 06/13/17, 11:01
-
TYPO3com voted on patch set 1 V -1 06/13/17, 11:12 Completed build in 10m 17s on Tue, 13 Jun, 01:12 PM Test Summary: 6 of 56520 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12545
-
Benni Mack uploaded patch set 2 06/13/17, 11:47
-
TYPO3com voted on patch set 2 V +1 06/13/17, 11:57 Completed build in 10m 11s on Tue, 13 Jun, 01:57 PM Test Summary: 56517 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12548
-
Benni Mack uploaded patch set 3 06/15/17, 05:45
-
TYPO3com voted on patch set 3 V -1 06/15/17, 05:55 Completed build in 10m 43s on Thu, 15 Jun, 07:55 AM Test Summary: 56532 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12591
-
TYPO3com commented on patch set 3 06/15/17, 06:03 Completed build in 28m 34s on Thu, 15 Jun, 08:03 AM Test Summary: 56532 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12591
-
Benni Mack uploaded patch set 4 06/15/17, 06:04
-
TYPO3com voted on patch set 4 V +1 06/15/17, 06:14 Completed build in 10m 23s on Thu, 15 Jun, 08:14 AM Test Summary: 56532 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12592
-
Georg Ringer uploaded patch set 5 07/14/17, 11:57
-
TYPO3com voted on patch set 5 V -1 07/14/17, 11:58 Completed build in 10s on Fri, 14 Jul, 01:58 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13153
-
Georg Ringer commented on patch set 5 V -1 07/14/17, 11:58
-1 the update query still fails, I don't know yet why -
TYPO3com commented on patch set 5 07/15/17, 15:30 Completed build in 01m 48s on Sat, 15 Jul, 05:30 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13153
-
Jan Helke uploaded patch set 6 07/15/17, 17:25
-
TYPO3com voted on patch set 6 V +1 07/15/17, 17:39 Completed build in 13m 53s on Sat, 15 Jul, 07:39 PM Test Summary: 56889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13257
-
Christian Kuhn commented on patch set 6 CR -1 07/15/17, 20:26
update wizard still does not work - did not transfer a "https://" info on my local run for an "external url" page for me.ext_localconf.php:57should be moved some lines below to the other newly v9 added wizards. -
Benni Mack uploaded patch set 7 08/22/17, 19:30
-
TYPO3com voted on patch set 7 V -1 08/22/17, 19:30 Completed build in 09s on Tue, 22 Aug, 09:30 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13946
-
Benni Mack uploaded patch set 8 08/22/17, 19:32
-
TYPO3com voted on patch set 8 V -1 08/22/17, 19:45 Completed build in 12m 49s on Tue, 22 Aug, 09:45 PM Test Summary: 57736 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13947
-
Benni Mack uploaded patch set 9 08/23/17, 16:35
-
TYPO3com voted on patch set 9 V -1 08/23/17, 16:47 Completed build in 12m 04s on Wed, 23 Aug, 06:47 PM Test Summary: 57736 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13969
-
Benni Mack uploaded patch set 10 08/23/17, 18:07
-
TYPO3com voted on patch set 10 V -1 08/23/17, 18:21 Completed build in 13m 11s on Wed, 23 Aug, 08:21 PM Test Summary: 1 of 58111 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13977
-
TYPO3com voted on patch set 10 V +1 08/24/17, 06:28 Completed build in 12h 34m 03s on Thu, 24 Aug, 08:28 AM Test Summary: 57748 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13977
-
Georg Ringer voted on patch set 10 CR +1 V +1 08/25/17, 09:07
-
Andreas Kienast voted on patch set 10 CR +2 V +2 08/25/17, 14:31
-
Gerrit merged patch set 10 08/25/17, 14:32