Review main Merged

53200[TASK] Move flash message handling from DocumentTemplate to own class

Georg Ringer CR +2 V +2 Normal +54 −31 updated 09/11/17, 12:18

Commit message

To simplify the class \TYPO3\CMS\Backend\Template\DocumentTemplate, the
AJAX based flash message handling is moved to an own class.

Adding a RST file will be added with other removals within DocumentTemplate.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Georg Ringer +1
    • Jan Stockfisch +1
    • Benni Mack +1
  • Verified V +2
    • Christian Kuhn +2
    • Georg Ringer +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1517

  1. Georg Ringer uploaded patch set 1 06/13/17, 12:35

  2. TYPO3com voted on patch set 1 V +1 06/13/17, 12:47 Completed build in 11m 37s on Tue, 13 Jun, 02:47 PM Test Summary: 56499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12550

  3. Mona Muzaffar voted on patch set 1 CR +1 06/16/17, 20:25

  4. Andreas Kienast commented on patch set 1 06/17/17, 11:48

    Any hint how this can be tested? I can't find any usage of the route flashmessages/render in the core.
  5. Stefan Neufeind commented on patch set 1 CR +1 V +1 06/17/17, 12:28

    @Andreas: can be tested with uploading in the filelist in BE
  6. Frank Nägler commented on patch set 1 06/17/17, 14:51

    FlashMessageAjaxController.php:35

    return type missing

    DocumentTemplate.php:844

    remove public method without deprecation and without breaking rst?
  7. Benni Mack commented on patch set 1 CR -1 06/17/17, 19:07

    I agree. We can do it really easily by just marking it as deprecating, and keeping the old method.
  8. Georg Ringer commented on patch set 1 07/05/17, 18:02

    I doubt anyone called this public method with a request + response. If someone is using it as ajax endpint, everything will still work
  9. Benni Mack commented on patch set 1 08/30/17, 09:26

    FlashMessageAjaxController.php:26

    any reason why this should extend from AbstractFormEngineAjaxController?
  10. Benni Mack uploaded patch set 2 09/10/17, 09:14

  11. Benni Mack voted on patch set 2 CR +1 V +1 09/10/17, 09:14

  12. TYPO3com voted on patch set 2 V +1 09/10/17, 09:34 Completed build in 20m 25s on Sun, 10 Sep, 11:34 AM Test Summary: 58140 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14788

  13. Stefan Neufeind voted on patch set 2 CR +1 09/10/17, 13:10

  14. Jan Stockfisch voted on patch set 2 CR +1 09/11/17, 07:56

  15. Georg Ringer voted on patch set 2 CR +1 V +1 09/11/17, 08:15

  16. Christian Kuhn voted on patch set 2 CR +2 V +2 09/11/17, 12:18

  17. Gerrit merged patch set 2 09/11/17, 12:18