Review main Merged

53202[TASK] Migrate cHash configuration on silent upgrade wizard

Benni Mack CR +2 V +2 Hard +298 −83 updated 09/09/17, 11:29

Commit message

The cHash calculation is done on every TYPO3 request, which is
really unnecessary overhead, as this could be taken care by the
SilentConfigurationUpgradeService once and store the new value.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Nathan Boiron +1
  • Verified V +2
    • Christian Kuhn +2
    • Nathan Boiron +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 2536

Show 711 earlier messages
  1. Benni Mack uploaded patch set 1 06/13/17, 15:19

  2. TYPO3com voted on patch set 1 V +1 06/13/17, 15:30 Completed build in 11m 05s on Tue, 13 Jun, 05:30 PM Test Summary: 56499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12553

  3. Benni Mack uploaded patch set 2 09/06/17, 05:16

  4. TYPO3com voted on patch set 2 V -1 09/06/17, 05:33 Completed build in 16m 07s on Wed, 6 Sep, 07:33 AM Test Summary: 10 of 58442 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14244

  5. Frans Saris commented on patch set 2 09/06/17, 09:46

    So we need a way to configure a value of type string[] in the install tool
  6. Romain Canon commented on patch set 2 09/07/17, 16:35

    Currently resolving conflicts, will push asap.
  7. Romain Canon uploaded patch set 3 09/07/17, 17:01

  8. TYPO3com voted on patch set 3 V +1 09/07/17, 17:18 Completed build in 17m 16s on Thu, 7 Sep, 07:18 PM Test Summary: 58125 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14346

  9. Romain Canon commented on patch set 3 09/07/17, 17:38

    I'll be working on the values editing in the install tool, stay tuned.
  10. Romain Canon uploaded patch set 4 09/08/17, 10:22

  11. TYPO3com voted on patch set 4 V -1 09/08/17, 10:42 Completed build in 20m 03s on Fri, 8 Sep, 12:42 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14434

  1. Benni Mack commented on patch set 4 09/08/17, 11:22

    you can now remove that line (and the "Only downside" line above) Can you also add a RST file?

    DefaultConfigurationDescription.yaml:444

    the following lines need to be removed now.

    LocalConfigurationValueService.php:63

    you can add a return annotations ": array"
  2. Romain Canon commented on patch set 1 09/08/17, 11:29

    Working on the unit test, I'll push a patch with what Benni previously asked.
  3. Romain Canon uploaded patch set 5 09/08/17, 11:45

  4. TYPO3com voted on patch set 5 V -1 09/08/17, 12:03 Completed build in 18m 02s on Fri, 8 Sep, 02:03 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14454

  5. Romain Canon uploaded patch set 6 09/08/17, 12:32

  6. TYPO3com voted on patch set 6 V -1 09/08/17, 12:33 Completed build in 01m 28s on Fri, 8 Sep, 02:33 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14468

  7. Benni Mack commented on patch set 7 09/08/17, 12:44

    Published edit on patch set 6.
  8. TYPO3com voted on patch set 7 V -1 09/08/17, 12:44 Completed build in 32s on Fri, 8 Sep, 02:44 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14476

  9. Benni Mack uploaded patch set 8 09/08/17, 12:44

  10. TYPO3com voted on patch set 8 V +1 09/08/17, 13:00 Completed build in 15m 00s on Fri, 8 Sep, 03:00 PM Test Summary: 56833 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14477

  11. Matthias Vogel voted on patch set 8 CR +1 09/08/17, 13:55

  12. Nathan Boiron uploaded patch set 9 09/08/17, 14:18

  13. Matthias Vogel voted on patch set 9 CR +1 09/08/17, 14:20

  14. Romain Canon voted on patch set 9 CR +1 V +1 09/08/17, 14:32

  15. TYPO3com voted on patch set 9 V +1 09/08/17, 14:35 Completed build in 16m 55s on Fri, 8 Sep, 04:35 PM Test Summary: 56833 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14518

  16. Christian Kuhn commented on patch set 9 CR -1 09/08/17, 15:04

    LocalConfigurationValueService.php:105

    please at least add an @todo that we're currently displaying array values as comma separeted list which will boom if a value has a comma. this needs further works, later.
  17. Romain Canon commented on patch set 9 09/08/17, 15:12

    LocalConfigurationValueService.php:105 Reply

    Actually the only way to get there is that the entry "description" is marked as an array type (configured in the new YAML file), so the actual value will always be an array. The ternary condition is here to prevent old string values that were migrated to array to actually make the implode break. It also prevents corrupted data from any external configuration change to make it break. For instance, an old configuration that is marked as an array and looks like: ``` $GLOBALS['TYPO3_CONF_VARS']['my_conf'] = 'foo,bar'; ``` Will be transparently transformed to: ``` $GLOBALS['TYPO3_CONF_VARS']['my_conf'] = ['foo' ,'bar']; ```
  18. Christian Kuhn commented on patch set 9 09/08/17, 21:24

    LocalConfigurationValueService.php:105 Reply

    yeah, fine. and it works for this case. but it can't be the final solution. thus, i only request an @todo comment here pointing out that this solution should be improved later.
  19. Romain Canon uploaded patch set 10 09/09/17, 08:39

  20. Romain Canon commented on patch set 9 09/09/17, 08:40

    LocalConfigurationValueService.php:105 Reply

    Done
  21. Nathan Boiron voted on patch set 10 CR +1 V +1 09/09/17, 08:50

  22. TYPO3com voted on patch set 10 V -1 09/09/17, 09:05 Completed build in 25m 17s on Sat, 9 Sep, 11:05 AM Test Summary: 1 of 57182 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14614

  23. TYPO3com voted on patch set 10 V +1 09/09/17, 11:13 Completed build in 2h 58m 19s on Sat, 9 Sep, 01:13 PM Test Summary: 56823 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14614

  24. Christian Kuhn voted on patch set 10 CR +2 V +2 09/09/17, 11:29

  25. Gerrit merged patch set 10 09/09/17, 11:29