Review TYPO3_8-7 Merged

53207[BUGFIX] Check for enabled devlog inside devLog()

Susi Moog CR +2 V +2 Easy +13 −24 updated 06/14/17, 15:42

Commit message

Calling GeneralUtility::devLog() can be called but
the method itself should check whether the devlog
is enabled, instead of having third-party code
rely on checking the option with an if statement.

This effectively removes the need for checks on
if (TYPO3_DLOG) and the other two constants TYPO3_ERROR_DLOG
and TYPO3_EXCEPTION_DLOG in all callers' code.

Review

  • Code review CR +2
    • Benni Mack +2
  • Verified V +2
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 35

  1. Susi Moog commented on patch set 1 06/14/17, 06:41

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 06/14/17, 06:53 Completed build in 11m 00s on Wed, 14 Jun, 08:53 AM Test Summary: 1 of 57911 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-386

  3. TYPO3com voted on patch set 1 V +1 06/14/17, 14:42 Completed build in 8h 11m 36s on Wed, 14 Jun, 04:42 PM Test Summary: 57908 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-386

  4. Benni Mack voted on patch set 1 CR +2 V +2 06/14/17, 15:42

  5. Gerrit merged patch set 1 06/14/17, 15:42