53208[BUGFIX] Use mb_* methods directly instead of CharsetConverter
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Markus Klein +1
- Wouter Wolters +1
- Anja Leichsenring +1
-
Verified V +2
- Benni Mack +2
- Markus Klein +1
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 10
- typo3/sysext/backend/Classes/Form/Wizard/SuggestWizardDefaultReceiver.php2+3 −6
- typo3/sysext/core/Classes/Page/PageRenderer.php7+18 −3
- typo3/sysext/core/Classes/Utility/GeneralUtility.php1+9 −4
- typo3/sysext/fluid/Classes/ViewHelpers/Format/CaseViewHelper.php+8 −4
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php4+10 −9
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php3+19 −6
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+2 −4
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+9 −7
- typo3/sysext/indexed_search/Classes/FileContentParser.php+1 −1
- typo3/sysext/indexed_search/Classes/Indexer.php+4 −5
Review log 2228
Show 23 earlier messages
-
Benni Mack uploaded patch set 1 06/14/17, 12:14
-
TYPO3com voted on patch set 1 V +1 06/14/17, 12:23 Completed build in 09m 43s on Wed, 14 Jun, 02:23 PM Test Summary: 56499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12569
-
Benni Mack updated the commit message in patch set 2 06/14/17, 12:34
-
TYPO3com voted on patch set 2 V +1 06/14/17, 12:44 Completed build in 09m 44s on Wed, 14 Jun, 02:44 PM Test Summary: 56499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12570
-
Benni Mack updated the commit message in patch set 3 06/14/17, 15:53
-
TYPO3com voted on patch set 3 V +1 06/14/17, 16:03 Completed build in 10m 18s on Wed, 14 Jun, 06:03 PM Test Summary: 56514 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12578
-
Georg Ringer voted on patch set 3 CR +1 V +1 06/14/17, 16:25
-
Markus Klein commented on patch set 3 CR -1 06/14/17, 20:53
-
Markus Klein commented on patch set 3 V -1 06/14/17, 21:03
PageRenderer.php:2090do we know a reason why this protection was installed here?PageRenderer.php:2108using this instead of ->conv() is only correct if $toCharset is utf8, I opt for hardcoding it therefore.ContentObjectRenderer.php:2295is it safe to kick the synonym-functionality of parse_charset. the mb_* do not do this.TypoScriptFrontendController.php:4187IMO this is not safe. this is only true if metaCharset is indeed utf8 -
Benni Mack commented on patch set 3 06/15/17, 04:47
SuggestWizardDefaultReceiver.php:177Replyyes, you're right!PageRenderer.php:2090ReplyYes. It was originally introduced here: https://github.com/TYPO3/TYPO3.CMS/commit/8254fad2ac7a4324521d275a76c29e660074b652 And then modified here: https://github.com/TYPO3/TYPO3.CMS/commit/32a0976eaeb35913689cea9c922dbd9ba6143b0dPageRenderer.php:2108Replyack!ContentObjectRenderer.php:2295Replyyes. that's what I meant in the first place. mb_* do have aliases for encodings, which you can use automatically. They do not only have the same but even more than we added originally: You can get all aliases for "ascii" here which you can use transparently as well: http://php.net/manual/en/function.mb-encoding-aliases.phpTypoScriptFrontendController.php:4187ReplyYes, true, it's not 100% safe, I will remove it from this change. However, this is indeed an interesting piece of code, as the current code never uses any mb_* code but just uses "kasper-unit-tested" home-made code, which is a bad idea instead of relying to proper and wide-spread mb_* functions. but will do that separately. -
Benni Mack uploaded patch set 4 06/15/17, 04:56
-
TYPO3com voted on patch set 4 V -1 06/15/17, 05:06 Completed build in 10m 34s on Thu, 15 Jun, 07:06 AM Test Summary: 36 of 56517 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12590
-
Markus Klein commented on patch set 3 06/15/17, 08:45
ContentObjectRenderer.php:2295ReplyThe docs isn't very clear about the handling of aliases and which are known. -
Benni Mack commented on patch set 3 06/15/17, 14:17
ContentObjectRenderer.php:2295ReplyI know, that's why I tested it :) -
TYPO3com commented on patch set 4 06/15/17, 14:24 Completed build in 9h 38m 24s on Thu, 15 Jun, 04:24 PM Test Summary: 36 of 56517 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12590
-
Benni Mack uploaded patch set 5 06/15/17, 16:49
-
TYPO3com voted on patch set 5 V +1 06/15/17, 17:00 Completed build in 10m 18s on Thu, 15 Jun, 07:00 PM Test Summary: 56514 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12601
-
Markus Klein commented on patch set 5 06/16/17, 08:53
PageRenderer.php:2090still not sure, why we can drop that? -
Benni Mack commented on patch set 5 06/16/17, 09:04
PageRenderer.php:2090Replyyou cannot switch the backend to sth else than UTF-8 (default since 4.5, hard-coded since 6.0 in about 500 places) - and charset is always UTF-8. Yes, there might be an extension that completely cracks up the backend with custom entrypoints (non-UTF8, and then a custom parameter for the charset other than UTF-8) but that is just plain "not according to the standards". Like somebody who still wants to run a latin1 DB - it might be possible, but we don't care about this use-case anymore. -
Markus Klein commented on patch set 5 CR +1 V +1 06/16/17, 09:58
PageRenderer.php:2090ReplyAh, I didn't think about the getCharSet in detail. clear then. -
Wouter Wolters voted on patch set 5 CR +1 06/16/17, 10:06
-
Anja Leichsenring voted on patch set 5 CR +1 V +1 06/16/17, 10:17
-
Benni Mack voted on patch set 5 CR +2 V +2 06/16/17, 10:19
-
Gerrit merged patch set 5 06/16/17, 10:19
-
Andreas Kienast commented on patch set 6 06/17/17, 11:53
GeneralUtility.php:264post -1: $len is undefined. -
Markus Klein commented on patch set 6 06/17/17, 19:35
will be fixed with https://review.typo3.org/53245 -
Markus Klein commented on patch set 6 06/20/17, 16:17
TypoScriptFrontendController.php:4175regression here: we lack a strtolower() here now, which was in the old parse_charset -
Stephan Großberndt commented on patch set 6 06/20/17, 16:28
SuggestWizardDefaultReceiver.php:177