Review main Merged

53230[BUGFIX] AdminPanel: Change fields for simulate time

Thorben Nissen CR +2 V +2 Easy +2 −1 updated 06/16/17, 11:36

Commit message

When entering a date string in the admin panel to simulate a certain
date/time and clicking the "update" button an exception it thrown. Due to
the names and ordering of the fields, the timestamp from the hidden field
gets overridden by the date string.

Move the hidden timestamp field after the human readable date string field
to avoid the timestamp being overridden by the date string. Add a comment
to explain the ordering and avoid future changes.

Review

  • Code review CR +2
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2
    • Benni Mack +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Thorben Nissen uploaded patch set 1 06/16/17, 06:33

  2. TYPO3com voted on patch set 1 V +1 06/16/17, 06:44 Completed build in 10m 15s on Fri, 16 Jun, 08:44 AM Test Summary: 56514 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12610

  3. Markus Klein commented on patch set 1 CR -1 06/16/17, 08:47

    sorry. but I'm not satisfied with the commit msg
    this is not a commit message title, but a bug report title. the title shall reflect what is changed.
    bug report text. please describe why this is the case and how the fix solves this.

    AdminPanelView.php:469

    being
  4. Thorben Nissen uploaded patch set 2 06/16/17, 09:10

  5. TYPO3com voted on patch set 2 V +1 06/16/17, 09:20 Completed build in 10m 20s on Fri, 16 Jun, 11:20 AM Test Summary: 56514 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12617

  6. Susi Moog voted on patch set 2 CR +1 06/16/17, 09:59

  7. Susi Moog voted on patch set 2 V +1 06/16/17, 10:20

  8. Benni Mack voted on patch set 2 CR +2 V +2 06/16/17, 11:36

  9. Gerrit merged patch set 2 06/16/17, 11:36

  10. Benni Mack commented on patch set 3 06/16/17, 11:36

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit c9363c54dc987ccd141347104339007d197a166a