Review TYPO3_8-7 Merged

53233[BUGFIX] Use mb_* methods directly instead of CharsetConverter

Benni Mack CR +2 V +2 Normal +83 −49 updated 06/16/17, 11:02

Commit message

There are several places where mb_* methods are still not used, although
they are even better to use instead of the $csConv->parseCharset() method
for instance, as it has more aliases defined already.

Same goes for "entities_to_utf8" which is a PHP user-space implementation
of html_entity_decode() dated back to Kaspers' change in 2003.

Using native PHP methods should also increase performance marginally.

Review

  • Code review CR +2
    • Benni Mack +2
  • Verified V +2
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 10

Review log 34

  1. Benni Mack uploaded patch set 1 06/16/17, 10:21

  2. TYPO3com voted on patch set 1 V +1 06/16/17, 10:37 Completed build in 15m 56s on Fri, 16 Jun, 12:37 PM Test Summary: 57923 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-404

  3. Benni Mack voted on patch set 1 CR +2 V +2 06/16/17, 11:02

  4. Gerrit merged patch set 1 06/16/17, 11:02