Review main Merged

53236[BUGFIX] Streamline bool arguments throughout the core

Benni Mack CR +2 V +2 Easy +5 −5 updated 06/17/17, 14:37

Commit message

There are still places left in TYPO3 where methods are called with
integers as parameters, although they are marked as boolean.

These places are changed to the correct and necessary value.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Stefan Neufeind +1
    • Andreas Kienast +1
  • Verified V +2
    • Frank Nägler +2
    • Stefan Neufeind +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 67

  1. Benni Mack uploaded patch set 1 06/16/17, 11:10

  2. TYPO3com voted on patch set 1 V +1 06/16/17, 11:22 Completed build in 12m 19s on Fri, 16 Jun, 01:22 PM Test Summary: 56514 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12624

  3. Stefan Neufeind commented on patch set 1 CR +1 V +1 06/17/17, 12:33

    Checked that those functions adjusted here are called correctly in other places in the core as well.
  4. Andreas Kienast commented on patch set 1 CR -1 06/17/17, 12:37

    on it
  5. Andreas Kienast voted on patch set 1 CR +1 06/17/17, 12:54

  6. Frank Nägler voted on patch set 1 CR +2 V +2 06/17/17, 14:37

  7. Gerrit merged patch set 1 06/17/17, 14:37