Review main Merged Breaking

53237[!!!][TASK] Remove TYPO3.jQuery

Benni Mack CR +2 V +2 Normal +125 −47 updated 09/09/17, 08:36

Commit message

This change removes the availability of TYPO3.jQuery within the
TYPO3 Core by default.

The constants PageRenderer::JQUERY_NAMESPACE_DEFAULT / and
PageRenderer: JQUERY_NAMESPACE_DEFAULT_NOCONFLICT namespace options
"jQuery" are removed. This also means the removal
of having custom namespaces of jQuery (e.g. TYPO3.bennis_jQuery) leaving
"noConflict" to be used by default.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2
    • Andreas Kienast +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 2

Files 12

Review log 1625

  1. Benni Mack uploaded patch set 1 06/16/17, 11:32

  2. TYPO3com voted on patch set 1 V -1 06/16/17, 11:44 Completed build in 11m 57s on Fri, 16 Jun, 01:44 PM Test Summary: 24 of 56516 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12625

  3. TYPO3com voted on patch set 1 V +1 07/03/17, 07:37 Completed build in 20h 16m 52s on Mon, 3 Jul, 09:37 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12625

  4. Andreas Kienast commented on patch set 1 CR -2 09/08/17, 10:41

    Working on it
  5. Andreas Kienast uploaded patch set 2 09/08/17, 11:36

  6. TYPO3com voted on patch set 2 V -1 09/08/17, 12:21 Completed build in 44m 52s on Fri, 8 Sep, 02:21 PM Test Summary: 6 of 57180 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14452

  7. Andreas Kienast uploaded patch set 3 09/08/17, 13:15

  8. TYPO3com voted on patch set 3 V +1 09/08/17, 13:50 Completed build in 34m 55s on Fri, 8 Sep, 03:49 PM Test Summary: 56825 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14493

  9. Andreas Kienast updated the commit message in patch set 4 09/08/17, 13:53

  10. Andreas Kienast voted on patch set 4 CR 0 09/08/17, 13:53

  11. TYPO3com voted on patch set 4 V +1 09/08/17, 14:11 Completed build in 18m 21s on Fri, 8 Sep, 04:11 PM Test Summary: 56825 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14508

  12. Matthias Vogel voted on patch set 4 CR +1 09/08/17, 14:30

  13. Matthias Vogel voted on patch set 4 V +1 09/08/17, 14:35

  14. Benni Mack uploaded patch set 5 09/08/17, 15:04

  15. Andreas Kienast uploaded patch set 6 09/08/17, 15:11

  16. TYPO3com voted on patch set 5 V -1 09/08/17, 15:31 Completed build in 26m 02s on Fri, 8 Sep, 05:31 PM Test Summary: 4 of 57186 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14534

  17. Nathan Boiron commented on patch set 6 CR -1 09/08/17, 15:34

    PageRenderer.php:2172

    Is the switch really needed anymore? It could be a simple check if $namespace is different from self::JQUERY_NAMESPACE_NONE.

    ClassConstantMatcherTest.php:53

    Shouldn't there be a test for: TYPO3\CMS\Core\Page\PageRenderer::JQUERY_NAMESPACE_DEFAULT_NOCONFLICT ?
  18. TYPO3com voted on patch set 6 V +1 09/08/17, 15:39 Completed build in 28m 26s on Fri, 8 Sep, 05:39 PM Test Summary: 56829 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14536

  19. Andreas Kienast commented on patch set 6 09/08/17, 15:42

    ClassConstantMatcherTest.php:53 Reply

    Not necessarily, I just added a test to make sure I did everything right :)
  20. Benni Mack uploaded patch set 7 09/08/17, 23:12

  21. Benni Mack voted on patch set 7 CR +1 V +1 09/08/17, 23:12

  22. TYPO3com voted on patch set 7 V -1 09/08/17, 23:30 Completed build in 17m 39s on Sat, 9 Sep, 01:30 AM Test Summary: 1 of 57170 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14608

  23. TYPO3com voted on patch set 7 V +1 09/09/17, 08:35 Completed build in 9h 40m 17s on Sat, 9 Sep, 10:35 AM Test Summary: 56811 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14608

  24. Andreas Kienast voted on patch set 7 CR +2 V +2 09/09/17, 08:36

  25. Gerrit merged patch set 7 09/09/17, 08:36