Review TYPO3_8-7 Merged

53238[BUGFIX] AdminPanel: Change fields for simulate time

Benni Mack CR +2 V +2 Easy +2 −1 updated 06/16/17, 16:35

Commit message

When entering a date string in the admin panel to simulate a certain
date/time and clicking the "update" button an exception it thrown. Due to
the names and ordering of the fields, the timestamp from the hidden field
gets overridden by the date string.

Move the hidden timestamp field after the human readable date string field
to avoid the timestamp being overridden by the date string. Add a comment
to explain the ordering and avoid future changes.

Review

  • Code review CR +2
    • Benni Mack +2
  • Verified V +2
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 06/16/17, 11:36

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 06/16/17, 11:47 Completed build in 11m 04s on Fri, 16 Jun, 01:47 PM Test Summary: 57923 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-408

  3. Benni Mack voted on patch set 1 CR +2 V +2 06/16/17, 16:35

  4. Gerrit merged patch set 1 06/16/17, 16:35