Review TYPO3_7-6 Merged

53249[BUGFIX] Select suitable distribution version in em

Christian Kuhn CR +2 V +2 Normal +148 −45 updated 06/20/17, 09:54

Commit message

The distribution installer selects current_version=1
extensons only and fails in core v7 since the current
introduction version is not compatible with v7 anymore.

The patch changes version selection a bit to first find
all distribution extensions, then filters those suitable
for given core version, then filters latest version of
the distribution extension.

Installing introduction package in 7.6 works again.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Frank Nägler +1
    • Andreas Kienast +1
    • Jigal van Hemert +1
  • Verified V +2
    • Christian Kuhn +2
    • Frank Nägler +1
    • Jigal van Hemert +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1621

  1. Christian Kuhn uploaded patch set 1 06/18/17, 11:53

  2. Christian Kuhn commented on patch set 1 06/18/17, 11:54

    note: pushed to 7.6 first since it can be easily tested here. patch will then be "upmerged" to younger core versions.
  3. TYPO3com voted on patch set 1 V +1 06/18/17, 11:59 Completed build in 05m 39s on Sun, 18 Jun, 01:59 PM Test Summary: 38592 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-975

  4. Susi Moog commented on patch set 1 CR -1 06/18/17, 13:38

    ListController.php:237

    this method is only called for distributions anyway, so I'd very much prefer to have your filter code in there (and not here in the controller) - I mean, get Extensions suitable for TYPO3 version is exactly what the it does, especially in combination with the filter ;) Additionally the dependency utility has good test coverage *cough*
  5. Christian Kuhn commented on patch set 1 06/19/17, 09:09

    :P ... i'll see if i can come up with something.
  6. Christian Kuhn commented on patch set 1 06/19/17, 11:09

    i'll keep the method separate since the "show all versions, also not suitable" does not need the typo3 version filter.
  7. Christian Kuhn uploaded patch set 2 06/19/17, 12:27

  8. Christian Kuhn uploaded patch set 3 06/19/17, 12:30

  9. TYPO3com voted on patch set 2 V -1 06/19/17, 12:32 Completed build in 05m 30s on Mon, 19 Jun, 02:32 PM Test Summary: 4 of 38596 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-976

  10. TYPO3com voted on patch set 3 V +1 06/19/17, 12:36 Completed build in 05m 53s on Mon, 19 Jun, 02:36 PM Test Summary: 38596 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-977

  11. Susi Moog commented on patch set 3 CR -1 06/19/17, 13:08

    will take a closer look over the next hour(s)
  12. Susi Moog uploaded patch set 4 06/19/17, 16:52

  13. TYPO3com voted on patch set 4 V +1 06/19/17, 16:57 Completed build in 05m 28s on Mon, 19 Jun, 06:57 PM Test Summary: 38600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-978

  14. Frank Nägler voted on patch set 4 CR +1 V +1 06/19/17, 17:08

  15. Andreas Kienast commented on patch set 5 06/19/17, 19:19

    Published edit on patch set 4.
  16. Andreas Kienast commented on patch set 5 CR +1 06/19/17, 19:19

    Fixed a minor PSR-2 issue
  17. TYPO3com voted on patch set 5 V +1 06/19/17, 19:25 Completed build in 06m 22s on Mon, 19 Jun, 09:25 PM Test Summary: 38600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-979

  18. Frank Nägler voted on patch set 5 CR +1 V +1 06/19/17, 20:11

  19. Jigal van Hemert voted on patch set 5 CR +1 V +1 06/19/17, 21:15

  20. Christian Kuhn voted on patch set 5 CR +2 V +2 06/20/17, 09:53

  21. Gerrit merged patch set 5 06/20/17, 09:54