53249[BUGFIX] Select suitable distribution version in em
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Frank Nägler +1
- Andreas Kienast +1
- Jigal van Hemert +1
-
Verified V +2
- Christian Kuhn +2
- Frank Nägler +1
- Jigal van Hemert +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/extensionmanager/Classes/Controller/ListController.php1+5 −9
- typo3/sysext/extensionmanager/Classes/Domain/Repository/ExtensionRepository.php+0 −2
- typo3/sysext/extensionmanager/Classes/Utility/DependencyUtility.php+32 −0
- typo3/sysext/extensionmanager/Tests/Unit/Utility/DependencyUtilityTest.php+111 −34
Review log 1621
-
Christian Kuhn uploaded patch set 1 06/18/17, 11:53
-
Christian Kuhn commented on patch set 1 06/18/17, 11:54
note: pushed to 7.6 first since it can be easily tested here. patch will then be "upmerged" to younger core versions. -
TYPO3com voted on patch set 1 V +1 06/18/17, 11:59 Completed build in 05m 39s on Sun, 18 Jun, 01:59 PM Test Summary: 38592 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-975
-
Susi Moog commented on patch set 1 CR -1 06/18/17, 13:38
ListController.php:237this method is only called for distributions anyway, so I'd very much prefer to have your filter code in there (and not here in the controller) - I mean, get Extensions suitable for TYPO3 version is exactly what the it does, especially in combination with the filter ;) Additionally the dependency utility has good test coverage *cough* -
Christian Kuhn commented on patch set 1 06/19/17, 09:09
:P ... i'll see if i can come up with something. -
Christian Kuhn commented on patch set 1 06/19/17, 11:09
i'll keep the method separate since the "show all versions, also not suitable" does not need the typo3 version filter. -
Christian Kuhn uploaded patch set 2 06/19/17, 12:27
-
Christian Kuhn uploaded patch set 3 06/19/17, 12:30
-
TYPO3com voted on patch set 2 V -1 06/19/17, 12:32 Completed build in 05m 30s on Mon, 19 Jun, 02:32 PM Test Summary: 4 of 38596 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-976
-
TYPO3com voted on patch set 3 V +1 06/19/17, 12:36 Completed build in 05m 53s on Mon, 19 Jun, 02:36 PM Test Summary: 38596 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-977
-
Susi Moog commented on patch set 3 CR -1 06/19/17, 13:08
will take a closer look over the next hour(s) -
Susi Moog uploaded patch set 4 06/19/17, 16:52
-
TYPO3com voted on patch set 4 V +1 06/19/17, 16:57 Completed build in 05m 28s on Mon, 19 Jun, 06:57 PM Test Summary: 38600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-978
-
Frank Nägler voted on patch set 4 CR +1 V +1 06/19/17, 17:08
-
Andreas Kienast commented on patch set 5 06/19/17, 19:19
Published edit on patch set 4. -
Andreas Kienast commented on patch set 5 CR +1 06/19/17, 19:19
Fixed a minor PSR-2 issue -
TYPO3com voted on patch set 5 V +1 06/19/17, 19:25 Completed build in 06m 22s on Mon, 19 Jun, 09:25 PM Test Summary: 38600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-979
-
Frank Nägler voted on patch set 5 CR +1 V +1 06/19/17, 20:11
-
Jigal van Hemert voted on patch set 5 CR +1 V +1 06/19/17, 21:15
-
Christian Kuhn voted on patch set 5 CR +2 V +2 06/20/17, 09:53
-
Gerrit merged patch set 5 06/20/17, 09:54