Review main Merged

53258[BUGFIX] Refresh iconElement after its content has been replaced

Nikita Hovratov CR +2 V +2 Easy +1 −0 updated 10/18/17, 13:50

Commit message

The variable iconElement refers now correctly to the original jQuery
object and is really reverted to the old class as the comment implies.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Jörg Bösche +1
    • Andreas Kienast +1
  • Verified V +2
    • Christian Kuhn +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1620

  1. Nikita Hovratov uploaded patch set 1 06/18/17, 21:56

  2. TYPO3com voted on patch set 1 V +1 06/18/17, 22:05 Completed build in 09m 34s on Mon, 19 Jun, 12:05 AM Test Summary: 56498 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12675

  3. Riccardo De Contardi updated the commit message in patch set 2 09/02/17, 19:38

  4. TYPO3com voted on patch set 2 V +1 09/02/17, 19:51 Completed build in 13m 31s on Sat, 2 Sep, 09:51 PM Test Summary: 58061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14182

  5. Jörg Bösche commented on patch set 2 09/04/17, 06:38

    Please add the issue number from forge to your patch. If there is no forge issue for this bugfix, create a new one on https://forge.typo3.org/.
  6. Jörg Bösche voted on patch set 2 CR -1 09/04/17, 06:39

  7. Benni Mack commented on patch set 3 09/10/17, 10:12

    Published edit on patch set 2.
  8. Jörg Bösche voted on patch set 3 CR +1 09/10/17, 10:15

  9. TYPO3com voted on patch set 3 V +1 09/10/17, 10:30 Completed build in 18m 39s on Sun, 10 Sep, 12:30 PM Test Summary: 58140 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14801

  10. Stefan Neufeind commented on patch set 3 CR -1 09/10/17, 13:43

    still missing a forge-ticket-number in commit-msg
  11. Nikita Hovratov uploaded patch set 4 09/30/17, 16:42

  12. TYPO3com voted on patch set 4 V +1 09/30/17, 16:55 Completed build in 12m 53s on Sat, 30 Sep, 06:55 PM Test Summary: 56764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15225

  13. Jörg Bösche voted on patch set 4 CR +1 10/07/17, 16:54

  14. Andreas Kienast voted on patch set 4 CR +1 V +1 10/17/17, 12:12

  15. Christian Kuhn voted on patch set 4 CR +2 V +2 10/17/17, 20:14

  16. Gerrit merged patch set 4 10/17/17, 20:14

  17. Christian Kuhn commented on patch set 5 10/17/17, 20:14

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 13cbf8a40b18b3635c621cceaa17a697532af6be
  18. Markus Klein commented on patch set 5 10/17/17, 20:31

    AjaxDataHandler.js:182

    Just by reading the review here, I'm not sure why this line is needed at all. Why is $iconElement from line 173 not valid anymore at this point? Is the DOM-element thrown away due to the spinner?
  19. Andreas Kienast commented on patch set 5 10/18/17, 06:20

    Yes Markus, the element get completely replaces, thus the original reference is gone.
  20. Markus Klein commented on patch set 5 10/18/17, 13:50

    Alright. Thanks