Review main Merged

53260[BUGFIX] Fix wrong parameter type

Henrik Elsner CR +2 V +2 Easy +2 −2 updated 06/19/17, 11:30

Commit message

The quoting parameter constants \PDO::PARAM_* are in fact integers. The
annotation shipped with doctrine says string, and the strict type
processing in core leads to a wrong parameter error.
Changing the strict type to int, as would be correct, solves the problem.

Review

  • Code review CR +2
    • Markus Klein +2
    • Anja Leichsenring +1
  • Verified V +2
    • Markus Klein +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Henrik Elsner uploaded patch set 1 06/19/17, 10:57

  2. TYPO3com voted on patch set 1 V +1 06/19/17, 11:07 Completed build in 10m 10s on Mon, 19 Jun, 01:07 PM Test Summary: 56498 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12683

  3. Anja Leichsenring updated the commit message in patch set 2 06/19/17, 11:19

  4. Anja Leichsenring voted on patch set 2 CR +1 V +1 06/19/17, 11:19

  5. Markus Klein voted on patch set 2 CR +2 V +2 06/19/17, 11:23

  6. Markus Klein commented on patch set 2 CR -1 V 0 06/19/17, 11:25

    just a sec
  7. Markus Klein voted on patch set 2 CR +2 V +2 06/19/17, 11:26

  8. TYPO3com voted on patch set 2 V +1 06/19/17, 11:30 Completed build in 10m 38s on Mon, 19 Jun, 01:30 PM Test Summary: 56498 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12684

  9. Gerrit merged patch set 2 06/19/17, 11:30

  10. Markus Klein commented on patch set 3 06/19/17, 11:30

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 5f20bd3125be3fffb809680943cdd73115d3eff2