Review TYPO3_8-7 Merged

53261[BUGFIX] Fix wrong parameter type

Markus Klein CR +2 V +2 Easy +2 −2 updated 06/19/17, 11:42

Commit message

The quoting parameter constants \PDO::PARAM_* are in fact integers. The
annotation shipped with doctrine says string, and the strict type
processing in core leads to a wrong parameter error.
Changing the strict type to int, as would be correct, solves the problem.

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Markus Klein commented on patch set 1 06/19/17, 11:30

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 06/19/17, 11:41 Completed build in 10m 12s on Mon, 19 Jun, 01:41 PM Test Summary: 57935 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-425

  3. Markus Klein voted on patch set 1 CR +2 V +2 06/19/17, 11:42

  4. Gerrit merged patch set 1 06/19/17, 11:42