53263[FEATURE] Cleanup buildQueryParameters hook
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Frank Nägler +1
- Henrik Elsner +1
-
Verified V +2
- Christian Kuhn +2
- Henrik Elsner +1
- TYPO3com +1 CI
Issues 1
Files 3
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-81651-ArgumentParametersInListModuleHook.rstnew+34 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-81651-QueryBuilderObjectAsArgumentInListModuleHook.rstnew+24 −0
- typo3/sysext/recordlist/Classes/RecordList/AbstractDatabaseRecordList.php33+115 −75
Review log 2736
Show 711 earlier messages
-
Frank Nägler uploaded patch set 1 06/19/17, 20:32
-
TYPO3com voted on patch set 1 V +1 06/19/17, 20:41 Completed build in 09m 06s on Mon, 19 Jun, 10:41 PM Test Summary: 56498 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12693
-
Frank Nägler uploaded patch set 2 06/19/17, 21:01
-
Frank Nägler uploaded patch set 3 06/19/17, 21:03
-
TYPO3com voted on patch set 2 V +1 06/19/17, 21:12 Completed build in 11m 06s on Mon, 19 Jun, 11:12 PM Test Summary: 56498 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12694
-
TYPO3com voted on patch set 3 V +1 06/19/17, 21:14 Completed build in 10m 53s on Mon, 19 Jun, 11:14 PM Test Summary: 56498 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12695
-
Henrik Elsner commented on patch set 3 V -1 06/21/17, 08:43
the list modul is not working because of an array which is not changed into a string. AFAIS this results from the constraints in line ~830. -
Frank Nägler uploaded patch set 4 06/21/17, 08:54
-
TYPO3com voted on patch set 4 V +1 06/21/17, 09:04 Completed build in 09m 44s on Wed, 21 Jun, 11:04 AM Test Summary: 56528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12748
-
Henrik Elsner voted on patch set 4 CR +1 06/21/17, 09:18
-
Henrik Elsner updated the commit message in patch set 5 06/21/17, 09:40
-
Henrik Elsner commented on patch set 5 V +1 06/21/17, 09:41
rst-file missing -
Henrik Elsner voted on patch set 5 V -1 06/21/17, 09:41
-
TYPO3com voted on patch set 5 V +1 06/21/17, 09:51 Completed build in 10m 50s on Wed, 21 Jun, 11:51 AM Test Summary: 56528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12749
-
Frank Nägler uploaded patch set 6 06/21/17, 19:23
-
Henrik Elsner voted on patch set 6 CR +1 06/21/17, 19:28
-
TYPO3com voted on patch set 6 V -1 06/21/17, 20:16 Completed build in 11m 56s on Wed, 21 Jun, 10:16 PM Test Summary: 56528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12762
-
Morton Jonuschat commented on patch set 6 CR -1 06/21/17, 22:07
A bit more information in the commit message and the issue would be great. I'm also not certain this classifies as a task, it seems more like a Feature to me (and the RST seems to indicate the same).AbstractDatabaseRecordList.php:32This should not be in hereAbstractDatabaseRecordList.php:504Why is the return value of getPageIdConstraint not used? Leftover from refactor?AbstractDatabaseRecordList.php:670No empty line before @returnAbstractDatabaseRecordList.php:689What's the reason for this?AbstractDatabaseRecordList.php:695Is buildQueryParameters the right method name after the refactor? It seems to return a QueryBuilder now.AbstractDatabaseRecordList.php:701Description seems not to match what the method does.AbstractDatabaseRecordList.php:705No empty line before @returnAbstractDatabaseRecordList.php:716This is not the way to do it, only MySQL uses backticks. Postgres uses double quotes, MSSQL uses square brackets. It also doesn't take into account that there might be stuff in the table name that needs to be unquoted as well.AbstractDatabaseRecordList.php:719This is a change, the fieldnames are now quoted as well.AbstractDatabaseRecordList.php:741This method name/mode of operation takes a lot of inside knowledge, we should really change that.AbstractDatabaseRecordList.php:773This might be very different from the previous input and might affect/break hooks that expected the piece-by-piece additional constraints. This alone probably warrants a [!!!] declaration and a Breaking-RSTAbstractDatabaseRecordList.php:821No empty line before @returnAbstractDatabaseRecordList.php:835What's the reason for this?AbstractDatabaseRecordList.php:841misleading method nameAbstractDatabaseRecordList.php:1351Description doesn't match what's happening in the methodAbstractDatabaseRecordList.php:1356method doesn't return anything, getPageIdConstraint name is very misleading, especially as it modifies the QueryBuilder that gets passed in. -
Frank Nägler commented on patch set 6 CR -1 06/21/17, 22:37
thx for your feedback Morton, I will push an update tomorrowAbstractDatabaseRecordList.php:689Replythe idea was that you can use addWhere in the hook every time.AbstractDatabaseRecordList.php:716Replygood point, will change itAbstractDatabaseRecordList.php:719Replythx, will change it -
Frank Nägler commented on patch set 6 06/22/17, 09:29
will push an update shortlyAbstractDatabaseRecordList.php:32ReplyDoneAbstractDatabaseRecordList.php:504Replyno return anymore, I will rename this method to addPageIdConstraintAbstractDatabaseRecordList.php:689ReplyI have checked it again and I think we need it to be compatible with the old hookAbstractDatabaseRecordList.php:695ReplyIt is the name of the hook, not sure if we should rename it. I will discuss it with Lolli today.AbstractDatabaseRecordList.php:701ReplyDoneAbstractDatabaseRecordList.php:716ReplyDoneAbstractDatabaseRecordList.php:719ReplyDoneAbstractDatabaseRecordList.php:741Replyname changed to addPageIdConstraintAbstractDatabaseRecordList.php:1351ReplyDoneAbstractDatabaseRecordList.php:1356ReplyDone -
Frank Nägler uploaded patch set 7 06/22/17, 10:35
-
TYPO3com voted on patch set 7 V +1 06/22/17, 10:46 Completed build in 10m 42s on Thu, 22 Jun, 12:46 PM Test Summary: 56528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12778
-
Christian Kuhn commented on patch set 7 CR -1 06/29/17, 09:25
on it. -
Christian Kuhn uploaded patch set 8 06/29/17, 10:23
-
Christian Kuhn commented on patch set 8 06/29/17, 10:24
AbstractDatabaseRecordList.php:716uhm ... no ;)AbstractDatabaseRecordList.php:774this returns fileds quoted already, use $fieldList again.AbstractDatabaseRecordList.php:789nice solutionAbstractDatabaseRecordList.php:1366createNamedParameter can be used now. -
Frank Nägler voted on patch set 8 CR +1 06/29/17, 10:27
-
TYPO3com voted on patch set 8 V +1 06/29/17, 10:33 Completed build in 10m 27s on Thu, 29 Jun, 12:33 PM Test Summary: 56733 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12881
-
Henrik Elsner voted on patch set 8 CR +1 06/29/17, 10:34
-
Henrik Elsner voted on patch set 8 V +1 06/29/17, 10:43
-
Georg Ringer commented on patch set 8 06/29/17, 10:49
this should be then a FEATURE? -
Christian Kuhn updated the commit message in patch set 9 06/29/17, 11:38
-
TYPO3com voted on patch set 9 V +1 06/29/17, 11:48 Completed build in 10m 30s on Thu, 29 Jun, 01:48 PM Test Summary: 56733 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12886
-
Frank Nägler voted on patch set 9 CR +1 06/29/17, 11:50
-
Henrik Elsner voted on patch set 9 CR +1 V +1 06/29/17, 11:55
-
Christian Kuhn voted on patch set 9 CR +2 V +2 06/29/17, 11:59
-
Gerrit merged patch set 9 06/29/17, 11:59