5327[BUGFIX] Don't save form protection error messages in session
Commit message
Review
-
Code review CR +2
- Tolleiv Nietsch +2
- Georg Ringer +1
- Oliver Klee +1
- Philipp Gampe +1
-
Verified V +2
- Tolleiv Nietsch +2
- Georg Ringer +1
- Philipp Gampe +1
Issues 1
Files 2
Review log 19
-
Oliver Klee commented on patch set 1 02/07/12, 07:27
I would prefer that you didn't submit thistrailing whitespaceclass.t3lib_formprotection_backendformprotection.php:134I'd prefer this to be in a local variable "inAjaxContext" or something like that. Then you don't need the comment either. (This comment is a sign that the code is not clear enough.)class.t3lib_formprotection_BackendFormProtectionTest.php:237Please use assertNotEmpty instead (as the first assertion before the assertContains). The general rule is: No conditions in unit tests (except for an if for cases when a test needs to be skipped, e.g., for certain TYPO3 versions or when a PHP extension is not installed).class.t3lib_formprotection_BackendFormProtectionTest.php:238I'd prefer an assertNotEmpty here so we don't need to have any conditional logic inside the unit tests. (The test function will exit at the point where an assertion fails.)class.t3lib_formprotection_BackendFormProtectionTest.php:259Ditto.class.t3lib_formprotection_BackendFormProtectionTest.php:259Ditto. -
Oliver Klee commented on patch set 2 2 comments 02/07/12, 07:27
I would prefer that you didn't submit this -
Oliver Klee commented on patch set 2 02/07/12, 07:27
(1 inline comment) -
Oliver Hader uploaded patch set 2 02/07/12, 07:27
-
Oliver Hader commented on patch set 2 02/07/12, 07:27
I would prefer that you didn't submit this Rebasing to master V:0, R:-1 V:0, R:-1 from Oliver Klee <typo3-coding@oliverklee.de> V:0, R:1 from Georg Ringer <mail@ringerge.org> -
Helmut Hummel commented on patch set 2 02/07/12, 07:27
(2 inline comments)class.t3lib_formprotection_BackendFormProtectionTest.php:238ReplyHow to avoid the PHP fatal error then if $messages is empty? $messages[0]->render()class.t3lib_formprotection_BackendFormProtectionTest.php:238ReplyAh, OK cool. I didn't know that.class.t3lib_formprotection_BackendFormProtectionTest.php:259Replyditto -
Helmut Hummel commented on patch set 2 02/07/12, 07:27
(1 inline comment) -
Tolleiv Nietsch commented on patch set 3 V 0 02/07/12, 07:27
by team member; Looks good to me, approved Good one :) -
Oliver Klee commented on patch set 3 02/07/12, 07:27
Looks good to me, but someone else must approve -
Helmut Hummel uploaded patch set 3 02/07/12, 07:27
-
Helmut Hummel commented on patch set 3 02/07/12, 07:27
(1 inline comment) -
Georg Ringer commented on patch set 1 02/07/12, 07:27
Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 3 02/07/12, 07:27
(1 inline comment)class.t3lib_formprotection_BackendFormProtectionTest.php:249what does this test do, which is not tested before? -
Philipp Gampe commented on patch set 3 02/07/12, 07:27
Verified; Looks good to me, but someone else must approve Ah ok. -
Mr. Jenkins commented on patch set 1 02/07/12, 07:27
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1965/ : SUCCESS -
Mr. Jenkins commented on patch set 2 02/07/12, 07:27
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2685/ : SUCCESS -
Mr. Jenkins commented on patch set 3 02/07/12, 07:27
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3116/ : SUCCESS -
Georg Ringer commented on patch set 3 02/07/12, 07:27
Verified; Looks good to me, but someone else must approve -
Georg Ringer merged patch set 3 02/07/12, 07:27