Review main Merged

53273[BUGFIX] Always select database number in Redis Cache Backend

Kasper Ligaard CR +2 V +2 Easy +1 −1 updated 07/04/17, 20:17

Commit message

When using persistent connections, we need to always select the database.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Thomas Hohn +1
    • Markus Klein +1
    • Frank Nägler +1
    • Andreas Kienast +1
    • Jörg Bösche +1
  • Verified V +2
    • Christian Kuhn +2
    • Thomas Hohn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 2430

Show 45 earlier messages
  1. Kasper Ligaard uploaded patch set 1 06/20/17, 09:45

  2. TYPO3com voted on patch set 1 V +1 06/20/17, 09:59 Completed build in 13m 35s on Tue, 20 Jun, 11:59 AM Test Summary: 56498 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12716

  3. Wouter Wolters commented on patch set 1 CR -1 06/20/17, 10:02

    IMO we do not mark this as follow up.
  4. Kasper Ligaard commented on patch set 1 06/20/17, 10:03

    @wouter: Simply bugfix then?
  5. Kasper Ligaard updated the commit message in patch set 2 06/20/17, 10:10

  1. Kasper Ligaard uploaded patch set 3 06/20/17, 10:13

  2. TYPO3com voted on patch set 2 V +1 06/20/17, 10:26 Completed build in 16m 13s on Tue, 20 Jun, 12:26 PM Test Summary: 56498 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12722

  3. TYPO3com voted on patch set 3 V +1 06/20/17, 10:29 Completed build in 16m 14s on Tue, 20 Jun, 12:29 PM Test Summary: 56498 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12723

  4. Mads Lønne Jensen commented on patch set 3 CR -1 06/20/17, 11:09

    RedisBackend.php:171

    Having 'persistentConnection' truthy does not imply that 'database' is a valid database number.
  5. Kasper Ligaard uploaded patch set 4 06/20/17, 11:50

  6. Mads Lønne Jensen voted on patch set 4 CR +1 06/20/17, 11:51

  7. Kasper Ligaard commented on patch set 4 06/20/17, 11:53

    PS4: making it clearer that zero needs to be included, when persistent connections are used. (Also guarding against database being below zero, although that would be really weird!)
  8. TYPO3com voted on patch set 4 V +1 06/20/17, 12:03 Completed build in 12m 31s on Tue, 20 Jun, 02:03 PM Test Summary: 56528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12732

  9. Mads Lønne Jensen voted on patch set 4 V +1 06/20/17, 12:08

  10. Markus Klein commented on patch set 4 06/20/17, 12:15

    RedisBackend.php:171

    Can't we simply change that to >= 0 in general? selecting DB 0 shouldn't hurt anyway
  11. Kasper Ligaard commented on patch set 4 06/20/17, 12:19

    @markus: The thing is that for non-persistent connections this would change to now also always call select database even for db nr. zero. I am fine either way, so if you prefer PS1 we will do that. You call :-)
  12. Markus Klein commented on patch set 4 06/20/17, 12:32

    Well, if I understand correctly how Redis works, it will internally always need to select a DB. If you do not do via driver, it will use DB 0. So that really shouldn't make any difference.
  13. Kasper Ligaard commented on patch set 4 06/20/17, 12:43

    OK. PS1 it is then. Will upload in a moment.
  14. Kasper Ligaard uploaded patch set 5 06/20/17, 12:44

  15. TYPO3com voted on patch set 5 V -1 06/20/17, 12:56 Completed build in 11m 16s on Tue, 20 Jun, 02:56 PM Test Summary: 360 of 56531 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12733

  16. Kasper Ligaard uploaded patch set 6 06/20/17, 12:58

  17. TYPO3com commented on patch set 6 06/20/17, 13:08 Completed build in 09m 33s on Tue, 20 Jun, 03:08 PM Test Summary: 56528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12734

  18. Markus Klein voted on patch set 6 CR +1 06/20/17, 13:13

  19. Thomas Hohn voted on patch set 6 CR +1 V +1 06/21/17, 09:56

  20. Andreas Kienast voted on patch set 6 CR +1 06/21/17, 11:23

  21. Frank Nägler voted on patch set 6 CR +1 06/21/17, 19:48

  22. Jörg Bösche voted on patch set 6 CR +1 07/03/17, 06:10

  23. Christian Kuhn voted on patch set 6 CR +2 V +2 07/04/17, 20:17

  24. Gerrit merged patch set 6 07/04/17, 20:17

  25. Christian Kuhn commented on patch set 7 07/04/17, 20:17

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit a2dd4b8792324e941af73b1fbed8eebcb2a3ae9e