Review TYPO3_7-6 Merged

53282[BUGFIX] Prevent uncaught exception in Import/Export controller

Susi Moog CR +2 V +2 Easy +22 −0 updated 06/20/17, 12:08

Commit message

Currently an error is thrown if no post data was sent to the
ImportExportController. This can easily happen if a t3d file should
be uploaded but is larger than the configured post_max_size of the
server. This patch checks the incoming information, sets the import
action as default and displays an information to the user that he/she
may have tried to upload a file that was too large.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 46

  1. Susi Moog uploaded patch set 1 06/20/17, 11:54

  2. Benni Mack updated the commit message in patch set 2 06/20/17, 11:56

  3. TYPO3com voted on patch set 1 V +1 06/20/17, 12:01 Completed build in 06m 31s on Tue, 20 Jun, 02:01 PM Test Summary: 38600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-981

  4. TYPO3com voted on patch set 2 V +1 06/20/17, 12:04 Completed build in 07m 32s on Tue, 20 Jun, 02:04 PM Test Summary: 38600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-982

  5. Christian Kuhn commented on patch set 2 CR +2 V +2 06/20/17, 12:08

    retested in 7.6 with a tiny post_max_size setting. works.
  6. Gerrit merged patch set 2 06/20/17, 12:08