53291[BUGFIX] Fix checking config.metaCharset with uppercase letters
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Stephan Großberndt +1
- Markus Klein +1
-
Verified V +2
- Benni Mack +2
- Markus Klein +1
- TYPO3com +1 CI
Issues 1
Files 4
Review log 911
-
Stephan Großberndt uploaded patch set 1 06/20/17, 16:26
-
Benni Mack uploaded patch set 2 06/20/17, 16:37
-
Markus Klein voted on patch set 2 CR +1 06/20/17, 16:42
-
TYPO3com voted on patch set 1 V +1 06/20/17, 16:50 Completed build in 24m 21s on Tue, 20 Jun, 06:50 PM Test Summary: 56528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12738
-
Markus Klein commented on patch set 2 06/20/17, 16:52
-
Markus Klein commented on patch set 2 V +1 06/20/17, 16:55
looks good so far. checked all places where mb_* functions are used and charsets are involved.TypoScriptFrontendController.php:4218ReplyAnswer to myself: no, not really necessary. -
Benni Mack commented on patch set 2 06/20/17, 16:55
TypoScriptFrontendController.php:4218ReplyThat's probably to be 1000% sure (in case an extension resets metaCharset again to sth else) - There are two places (PageRenderer and here) where we use this, but IMHO the outer method (here convPOSTCharset()) should hand in the lowered method then, as this method is protected. -
TYPO3com voted on patch set 2 V +1 06/20/17, 16:59 Completed build in 22m 21s on Tue, 20 Jun, 06:59 PM Test Summary: 56528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12740
-
Stephan Großberndt voted on patch set 2 CR +1 06/20/17, 20:55
-
Benni Mack voted on patch set 2 CR +2 V +2 06/21/17, 04:27
-
Gerrit merged patch set 2 06/21/17, 04:27
TypoScriptFrontendController.php:4218