Review main Merged

53296[TASK] Upgrade version of D3 to 4.9.1

Anders Kostending CR +2 V +2 Normal +61 −93 updated 07/05/17, 13:04

Commit message

This updates the version of D3 to the latest
release, 4.9.1.

The realese can be seen here: https://github.com/d3/d3/releases

A lot of fixes have been added in the latest versions.

v4.8.0:
 * Add d3.tickIncrement.
 * Fix d3.ticks to always return the most-precise representable
   values in IEEE 754!
 * Fix histogram.thresholds to retain thresholds equal to the
   domain’s upper bound.
 * Number format locales can now override the percent sign suffix.
   Thanks, @davinov!

v4.9.0:
 * Change selection.style to return the inline style, if present.
 * Change transition.style to start from the inline style,
   if present.
 * Add link shapes!
 * Add d3.stackOffsetDiverging.
 * Add random.source to allow custom sources of randomness.
   Thanks, @rolyatmax!
 * Add drag.clickDistance for setting the click distance threshold.
   Thanks, @Epiphero!
 * Add zoom.clickDistance for setting the click distance threshold.
 * Add d3.style.
 * Fix rounding errors in continuous.nice.
 * Fix inconsistency between continuous.ticks and continous.nice.
   Thanks, @danielyule!
 * Fix axis tick offset for band and point scales.
 * Fix drag click suppression to ignore mousemove events that
   don’t actually move.
 * Fix zoom click suppression to ignore mousemove events that
   don’t actually move.
 * Fix error trying to interpolate objects without prototypes.
   Thanks, @devgru!
 * Optimize generated axis DOM slightly.
 * Improve error message descriptions in d3.queue.
   Thanks, @ethervoid!

v4.9.1:
 * Fix d3.linkRadial to use radians rather than degrees.
 * Optimize path.pointRadius slightly.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Kasper Ligaard +1
    • Frank Nägler +1
    • Anders Kostending +1
  • Verified V +2
    • Christian Kuhn +2
    • Frank Nägler +1
    • Anders Kostending +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1417

  1. Anders Kostending uploaded patch set 1 06/21/17, 10:56

  2. TYPO3com voted on patch set 1 V -1 06/21/17, 11:06 Completed build in 09m 45s on Wed, 21 Jun, 01:06 PM Test Summary: 56528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12750

  3. Anders Kostending commented on patch set 1 06/21/17, 11:55

    My googling let me here: https://github.com/npm/npm/issues/16677 It appears that the error could be in npm, what specific version are we using? It seems it failed at npm install, and that works fine for me locally.
  4. Anders Kostending commented on patch set 1 06/21/17, 12:18

    > My googling let me here: > https://github.com/npm/npm/issues/16677 > > It appears that the error could be in npm, what specific version > are we using? > > It seems it failed at npm install, and that works fine for me > locally. and i'm using npm 5.0.0-beta.69
  5. Andreas Kienast rebased onto patch set 2 06/21/17, 14:56

  6. TYPO3com voted on patch set 2 V -1 06/21/17, 15:07 Completed build in 11m 37s on Wed, 21 Jun, 05:07 PM Test Summary: 56528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12754

  7. Andreas Kienast uploaded patch set 3 06/22/17, 06:30

  8. Andreas Kienast commented on patch set 3 06/22/17, 06:35

    The failed test is positive now. You should upgrade nodejs to a current version, including npm 5.0.1 at least.
  9. TYPO3com voted on patch set 3 V +1 06/22/17, 06:40 Completed build in 09m 51s on Thu, 22 Jun, 08:40 AM Test Summary: 56528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12771

  10. Anders Kostending commented on patch set 3 06/22/17, 06:43

    Great, thanks, i'll take a look at that.
  11. Anders Kostending voted on patch set 3 CR +1 V +1 06/22/17, 07:00

  12. Kasper Ligaard voted on patch set 3 CR +1 07/01/17, 11:13

  13. Christian Kuhn voted on patch set 3 CR +1 V +1 07/05/17, 13:00

  14. Frank Nägler voted on patch set 3 CR +1 V +1 07/05/17, 13:01

  15. Christian Kuhn voted on patch set 3 CR +2 V +2 07/05/17, 13:04

  16. Gerrit merged patch set 3 07/05/17, 13:04

  17. Christian Kuhn commented on patch set 4 07/05/17, 13:04

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit ad185fa3c110a83e9b4d74083793c87d1f53a7bb