53296[TASK] Upgrade version of D3 to 4.9.1
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Kasper Ligaard +1
- Frank Nägler +1
- Anders Kostending +1
-
Verified V +2
- Christian Kuhn +2
- Frank Nägler +1
- Anders Kostending +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1417
-
Anders Kostending uploaded patch set 1 06/21/17, 10:56
-
TYPO3com voted on patch set 1 V -1 06/21/17, 11:06 Completed build in 09m 45s on Wed, 21 Jun, 01:06 PM Test Summary: 56528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12750
-
Anders Kostending commented on patch set 1 06/21/17, 11:55
My googling let me here: https://github.com/npm/npm/issues/16677 It appears that the error could be in npm, what specific version are we using? It seems it failed at npm install, and that works fine for me locally. -
Anders Kostending commented on patch set 1 06/21/17, 12:18
> My googling let me here: > https://github.com/npm/npm/issues/16677 > > It appears that the error could be in npm, what specific version > are we using? > > It seems it failed at npm install, and that works fine for me > locally. and i'm using npm 5.0.0-beta.69 -
Andreas Kienast rebased onto patch set 2 06/21/17, 14:56
-
TYPO3com voted on patch set 2 V -1 06/21/17, 15:07 Completed build in 11m 37s on Wed, 21 Jun, 05:07 PM Test Summary: 56528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12754
-
Andreas Kienast uploaded patch set 3 06/22/17, 06:30
-
Andreas Kienast commented on patch set 3 06/22/17, 06:35
The failed test is positive now. You should upgrade nodejs to a current version, including npm 5.0.1 at least. -
TYPO3com voted on patch set 3 V +1 06/22/17, 06:40 Completed build in 09m 51s on Thu, 22 Jun, 08:40 AM Test Summary: 56528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12771
-
Anders Kostending commented on patch set 3 06/22/17, 06:43
Great, thanks, i'll take a look at that. -
Anders Kostending voted on patch set 3 CR +1 V +1 06/22/17, 07:00
-
Kasper Ligaard voted on patch set 3 CR +1 07/01/17, 11:13
-
Christian Kuhn voted on patch set 3 CR +1 V +1 07/05/17, 13:00
-
Frank Nägler voted on patch set 3 CR +1 V +1 07/05/17, 13:01
-
Christian Kuhn voted on patch set 3 CR +2 V +2 07/05/17, 13:04
-
Gerrit merged patch set 3 07/05/17, 13:04
-
Christian Kuhn commented on patch set 4 07/05/17, 13:04
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit ad185fa3c110a83e9b4d74083793c87d1f53a7bb