53303[FEATURE] Add "required" argument to select view helper.
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Sascha Rademacher +1
-
Verified V +2
- Susi Moog +2
- Sascha Rademacher +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 2231
Show 46 earlier messages
-
Eike Starkmann uploaded patch set 1 06/21/17, 16:30
-
TYPO3com voted on patch set 1 V +1 06/21/17, 16:40 Completed build in 09m 37s on Wed, 21 Jun, 06:40 PM Test Summary: 56528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12757
-
Mona Muzaffar commented on patch set 1 CR -1 06/22/17, 05:00
Hey Eike, thanks for the patch. You need to add a few things to your patch in order to fit the guidelines. In your commit message, you need to refer to the branch for which this patch applies. In this case: 'Releases: master' since features are only added to the master branch. (see https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/singlehtml/#commit-message-rules-for-typo3-cms) A new feature also needs a feature rst, where you describe you the impact of your patch (this might help you - https://forger.typo3.org/utility/rst ) -
Eike Starkmann updated the commit message in patch set 2 06/22/17, 09:01
-
TYPO3com voted on patch set 2 V +1 06/22/17, 09:11 Completed build in 10m 38s on Thu, 22 Jun, 11:11 AM Test Summary: 56528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12774
-
Eike Starkmann uploaded patch set 3 06/22/17, 09:28
-
TYPO3com voted on patch set 3 V -1 06/22/17, 09:38 Completed build in 09m 30s on Thu, 22 Jun, 11:38 AM Test Summary: 56528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12775
-
Eike Starkmann uploaded patch set 4 06/22/17, 09:58
-
TYPO3com voted on patch set 4 V -1 06/22/17, 10:08 Completed build in 10m 02s on Thu, 22 Jun, 12:08 PM Test Summary: 56528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12776
-
Eike Starkmann uploaded patch set 5 06/22/17, 10:29
-
TYPO3com voted on patch set 5 V -1 06/22/17, 10:41 Completed build in 11m 47s on Thu, 22 Jun, 12:41 PM Test Summary: 56528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12777
-
Anja Leichsenring commented on patch set 5 06/26/17, 12:55
the errormessage from bamboo is raised because it can not properly retrieve the file. Don't use spaces in file names, but do the words division by dash. -
Eike Starkmann uploaded patch set 6 06/26/17, 13:48
-
TYPO3com voted on patch set 6 V +1 06/26/17, 13:59 Completed build in 10m 11s on Mon, 26 Jun, 03:59 PM Test Summary: 56727 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12844
-
Christian Kuhn uploaded patch set 7 06/26/17, 19:51
-
TYPO3com voted on patch set 7 V +1 06/26/17, 20:01 Completed build in 10m 25s on Mon, 26 Jun, 10:01 PM Test Summary: 56727 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12849
-
Christian Kuhn commented on patch set 7 CR +1 V +1 06/26/17, 20:03
Looks good to me. -
Georg Ringer commented on patch set 7 CR -1 06/27/17, 06:58
please add it then to all form viewhelper like password, checkbox, radio, ... -
Eike Starkmann commented on patch set 7 06/27/17, 10:38
Thinking about check boxes it is not so easy: What is the behaviour? All checkboxes are required or at least one? What about multiple? -
Jan Stockfisch voted on patch set 7 CR +1 07/12/17, 10:17
-
Georg Ringer commented on patch set 7 07/12/17, 12:28
single checkboxes, like agb -
Sascha Rademacher commented on patch set 7 CR -1 07/17/17, 08:13
Missing Test. -
Sascha Rademacher uploaded patch set 8 07/17/17, 08:32
-
Sascha Rademacher commented on patch set 7 07/17/17, 08:39
Each Viewhelper should have its own Ticket for seperate Discussions. -
TYPO3com voted on patch set 8 V +1 07/17/17, 08:42 Completed build in 09m 50s on Mon, 17 Jul, 10:42 AM Test Summary: 56877 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13285
-
Susi Moog uploaded patch set 9 07/17/17, 08:58
-
Susi Moog commented on patch set 9 CR +1 V +1 07/17/17, 08:59
just corrected a typo in rst file -
TYPO3com voted on patch set 9 V +1 07/17/17, 09:07 Completed build in 09m 15s on Mon, 17 Jul, 11:07 AM Test Summary: 56877 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13287
-
Sascha Rademacher voted on patch set 9 CR +1 V +1 07/17/17, 09:28
-
Susi Moog voted on patch set 9 CR +2 V +2 07/17/17, 09:35
-
Gerrit merged patch set 9 07/17/17, 09:36