Review main Merged

53309[BUGFIX] Add missing frontend context check when fetching view configuration

Xavier Perseguers CR +2 V +2 Normal +125 −3 updated 06/22/17, 22:54

Commit message

Check for Frontend context has been omitted during refactoring and will
have side effects in Backend in view configuration is overridden in
Frontend context.

Review

  • Code review CR +2
    • Markus Klein +2
    • Alexander Grein +1
  • Verified V +2
    • Markus Klein +2
    • Alexander Grein +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 1318

  1. Xavier Perseguers uploaded patch set 1 06/22/17, 14:55

  2. Wouter Wolters commented on patch set 1 06/22/17, 14:57

    I wouldn't name it a follow up but a clear bugfix.
  3. Wouter Wolters commented on patch set 1 06/22/17, 14:57

    as
  4. Wouter Wolters updated the commit message in patch set 2 06/22/17, 15:01

  5. TYPO3com voted on patch set 1 V -1 06/22/17, 15:06 Completed build in 10m 57s on Thu, 22 Jun, 05:06 PM Test Summary: 6 of 56711 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12782

  6. Xavier Perseguers commented on patch set 2 06/22/17, 15:11

    Great... so in addition to have introduced a regression, invalid unit tests have been added in faulty patchset :)
  7. TYPO3com voted on patch set 2 V -1 06/22/17, 15:13 Completed build in 12m 20s on Thu, 22 Jun, 05:13 PM Test Summary: 6 of 56711 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12783

  8. Claus Due uploaded patch set 3 06/22/17, 15:22

  9. Claus Due uploaded patch set 4 06/22/17, 15:23

  10. Claus Due commented on patch set 4 06/22/17, 15:23

    P4: just fixing a bad name for the last unit test I added.
  11. Claus Due uploaded patch set 5 06/22/17, 15:27

  12. TYPO3com voted on patch set 3 V -1 06/22/17, 15:34 Completed build in 12m 24s on Thu, 22 Jun, 05:34 PM Test Summary: 56720 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12787

  13. TYPO3com voted on patch set 4 V -1 06/22/17, 15:36 Completed build in 13m 27s on Thu, 22 Jun, 05:36 PM Test Summary: 56720 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12788

  14. TYPO3com voted on patch set 5 V +1 06/22/17, 15:40 Completed build in 12m 35s on Thu, 22 Jun, 05:40 PM Test Summary: 56720 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12789

  15. Alexander Grein voted on patch set 5 CR +1 V +1 06/22/17, 18:05

  16. Markus Klein voted on patch set 5 CR +2 V +2 06/22/17, 22:54

  17. Gerrit merged patch set 5 06/22/17, 22:54

  18. Markus Klein commented on patch set 6 06/22/17, 22:54

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit f8497c6a72c0e6161df3587009252a7483bec494