Review main Merged

53311[BUGFIX] Initialize uploadfolder key for TCA group file_reference

Sascha Egerer CR +2 V +2 Easy +39 −3 updated 06/28/17, 12:32

Commit message

The array key 'uploadfolder' is initialized on a non existing array.
It must be initialized on the processed tca array

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Henrik Elsner +1
  • Verified V +2
    • Christian Kuhn +2
    • Henrik Elsner +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1115

  1. Sascha Egerer uploaded patch set 1 06/22/17, 15:34

  2. TYPO3com voted on patch set 1 V -1 06/22/17, 15:58 Completed build in 24m 09s on Thu, 22 Jun, 05:58 PM Test Summary: 1 of 56711 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12790

  3. Sascha Egerer updated the commit message in patch set 2 06/22/17, 16:04

  4. TYPO3com voted on patch set 2 V -1 06/22/17, 16:18 Completed build in 14m 05s on Thu, 22 Jun, 06:18 PM Test Summary: 1 of 56711 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12793

  5. Sascha Egerer updated the commit message in patch set 3 06/23/17, 08:45

  6. TYPO3com voted on patch set 3 V +1 06/23/17, 08:55 Completed build in 09m 17s on Fri, 23 Jun, 10:55 AM Test Summary: 56720 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12798

  7. Georg Ringer voted on patch set 3 CR +1 06/26/17, 08:34

  8. Christian Kuhn commented on patch set 3 CR +1 V +1 06/27/17, 09:06

    file_reference is missing an example in styleguide, henrik will add some. change however is obvious and should do.
  9. Christian Kuhn commented on patch set 3 CR 0 06/27/17, 09:07

    if we feel lucky, we may add a unit test to tca group, though.
  10. Christian Kuhn uploaded patch set 4 06/28/17, 10:42

  11. Henrik Elsner voted on patch set 4 CR +1 V +1 06/28/17, 10:44

  12. TYPO3com voted on patch set 4 V +1 06/28/17, 10:52 Completed build in 10m 15s on Wed, 28 Jun, 12:52 PM Test Summary: 56733 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12864

  13. Christian Kuhn voted on patch set 4 CR +2 V +2 06/28/17, 10:53

  14. Gerrit merged patch set 4 06/28/17, 10:53

  15. Christian Kuhn commented on patch set 5 06/28/17, 12:32

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 164503d2e640a76f7a7e18a72d33815d4db98a88