Review main Merged

53318[BUGFIX] Revert and adjust changes in InstallFromTer.json

Andreas Kienast CR +2 V +2 Easy +9 −1 updated 06/26/17, 20:20

Commit message

The original patch removed variables that were assumed to be unused. The
assumption was wrong, as the variables are used in JavaScript context and
are thus now undefined.

This patch revert the changes done back then, but uses the f:format.json
view helper.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 56

  1. Andreas Kienast uploaded patch set 1 06/23/17, 19:11

  2. TYPO3com voted on patch set 1 V +1 06/23/17, 19:21 Completed build in 09m 32s on Fri, 23 Jun, 09:21 PM Test Summary: 56721 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12822

  3. Wouter Wolters voted on patch set 1 CR +1 06/24/17, 10:14

  4. Christian Kuhn voted on patch set 1 CR +1 V +1 06/26/17, 19:45

  5. Wouter Wolters voted on patch set 1 CR +2 V +2 06/26/17, 20:20

  6. Gerrit merged patch set 1 06/26/17, 20:20