Review main Merged

53324[TASK] typo3/testing-framework 1.1 brings phpunit 6.2

Christian Kuhn CR +2 V +2 Hard +371 −171 updated 06/26/17, 06:56

Commit message

Switching from 1.0 to 1.1 dependency for typo3/testing-framework
brings phpunit v6.2 which comes with namespaced classes.

This change is considered non-braeking since it is only a
core require-dev dependency.

Minor changes throught the tests:
* Fixing incomplete tests for exceptions
* A couple of namespaced phpunit class usages

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2
    • Christian Kuhn +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 1422

  1. Christian Kuhn uploaded patch set 1 06/25/17, 18:20

  2. TYPO3com voted on patch set 1 V -1 06/25/17, 18:29 Completed build in 09m 48s on Sun, 25 Jun, 08:29 PM Test Summary: 2178 of 21467 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12830

  3. Christian Kuhn uploaded patch set 2 06/25/17, 18:48

  4. Christian Kuhn uploaded patch set 3 06/25/17, 18:54

  5. TYPO3com voted on patch set 2 V -1 06/25/17, 18:58 Completed build in 10m 00s on Sun, 25 Jun, 08:58 PM Test Summary: 2350 of 57091 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12831

  6. Christian Kuhn uploaded patch set 4 06/25/17, 19:00

  7. TYPO3com voted on patch set 3 V -1 06/25/17, 19:04 Completed build in 09m 49s on Sun, 25 Jun, 09:04 PM Test Summary: 6 of 57091 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12832

  8. TYPO3com voted on patch set 4 V -1 06/25/17, 19:11 Completed build in 10m 44s on Sun, 25 Jun, 09:11 PM Test Summary: 6 of 57091 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12833

  9. Christian Kuhn uploaded patch set 5 06/25/17, 19:13

  10. TYPO3com voted on patch set 5 V -1 06/25/17, 19:23 Completed build in 10m 17s on Sun, 25 Jun, 09:23 PM Test Summary: 7 of 57091 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12834

  11. Christian Kuhn uploaded patch set 6 06/25/17, 19:33

  12. Christian Kuhn updated the commit message in patch set 7 06/25/17, 19:42

  13. Christian Kuhn voted on patch set 7 CR -2 06/25/17, 19:43

  14. TYPO3com voted on patch set 6 V +1 06/25/17, 19:43 Completed build in 09m 47s on Sun, 25 Jun, 09:43 PM Test Summary: 56727 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12835

  15. TYPO3com voted on patch set 7 V +1 06/25/17, 19:54 Completed build in 11m 04s on Sun, 25 Jun, 09:54 PM Test Summary: 56727 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12836

  16. Christian Kuhn uploaded patch set 8 06/25/17, 20:01

  17. TYPO3com voted on patch set 8 V +1 06/25/17, 20:13 Completed build in 11m 40s on Sun, 25 Jun, 10:13 PM Test Summary: 56727 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12837

  18. Christian Kuhn voted on patch set 8 CR 0 06/25/17, 20:14

  19. Benni Mack voted on patch set 8 CR +1 V +1 06/25/17, 20:14

  20. Christian Kuhn voted on patch set 8 CR +2 V +2 06/25/17, 20:21

  21. Gerrit merged patch set 8 06/25/17, 20:21

  22. Wouter Wolters commented on patch set 9 06/26/17, 06:56

    non-breaking
    through